[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #2063: 3.6: fixing licenses/NOTICE for console and server distributions

["Cole-Greer (via GitHub)" <gi...@apache.org>]

Cole-Greer commented on code in PR #2063:
URL: https://github.com/apache/tinkerpop/pull/2063#discussion_r1192623474


##########
gremlin-console/src/main/static/LICENSE:
##########
@@ -216,6 +216,10 @@ The Apache TinkerPop project bundles the following components under the BSD Lice
      minlog (com.esotericsoftware:minlog:1.3.0 - https://github.com/EsotericSoftware/minlog)
        - shaded in gremlin-shaded to org.apache.tinkerpop.shaded.minlog
        - for details, see licenses/minlog
+     Antlr4 (org.antlr:antlr4-runtime:4.9.1 - https://www.antlr.org) - for details, see licenses/antlr4

Review Comment:
   I'm certainly not an expert in this domain but my understanding was that for any dependency, including transitive ones, if any binary/source is packaged within our distribution then we need to meet any NOTICE/license obligations at the root level. If it is acceptable for those to be buried within the jar that contains the transitive dependency then ASM can definitely be removed here.
   
   On the other hand the ANTLR jar is directly included in lib directory in both the console and server distributions. In this case I don't think the license buried within the groovy jar is good enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org