You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by af...@apache.org on 2015/09/09 18:48:13 UTC
incubator-reef git commit: [REEF-667] Made IIDentifiable.Id immutable.
Repository: incubator-reef
Updated Branches:
refs/heads/master 875aaa0bc -> 02156e86e
[REEF-667] Made IIDentifiable.Id immutable.
Also, changed all implementations not to expose a setter.
JIRA:
[REEF-667](https://issues.apache.org/jira/browse/REEF-667)
Pull Request:
This closes #470
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/02156e86
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/02156e86
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/02156e86
Branch: refs/heads/master
Commit: 02156e86e66e8fe3b279713d19205a79ae6d5c54
Parents: 875aaa0
Author: Markus Weimer <we...@apache.org>
Authored: Tue Sep 8 13:17:44 2015 -0700
Committer: Andrew Chung <af...@gmail.com>
Committed: Wed Sep 9 09:46:38 2015 -0700
----------------------------------------------------------------------
lang/cs/Org.Apache.REEF.Common/Api/AbstractFailure.cs | 2 +-
.../Org.Apache.REEF.Common/Exceptions/EvaluatorException.cs | 1 -
lang/cs/Org.Apache.REEF.Common/Exceptions/JobException.cs | 1 -
.../cs/Org.Apache.REEF.Driver/Bridge/Events/ActiveContext.cs | 4 ----
.../Bridge/Events/AllocatedEvaluator.cs | 2 +-
.../cs/Org.Apache.REEF.Driver/Bridge/Events/ClosedContext.cs | 4 ----
.../Bridge/Events/CompletedEvaluator.cs | 4 ----
.../cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedTask.cs | 4 ----
.../Org.Apache.REEF.Driver/Bridge/Events/ContextMessage.cs | 1 -
.../cs/Org.Apache.REEF.Driver/Bridge/Events/FailedContext.cs | 4 ----
.../Org.Apache.REEF.Driver/Bridge/Events/FailedEvaluator.cs | 2 +-
lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedTask.cs | 2 +-
lang/cs/Org.Apache.REEF.Driver/Bridge/Events/RunningTask.cs | 5 -----
.../cs/Org.Apache.REEF.Driver/Bridge/Events/SuspendedTask.cs | 4 ----
lang/cs/Org.Apache.REEF.Utilities/IIdentifiable.cs | 8 +++++++-
15 files changed, 11 insertions(+), 37 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Common/Api/AbstractFailure.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Common/Api/AbstractFailure.cs b/lang/cs/Org.Apache.REEF.Common/Api/AbstractFailure.cs
index aa95829..cb1ac2a 100644
--- a/lang/cs/Org.Apache.REEF.Common/Api/AbstractFailure.cs
+++ b/lang/cs/Org.Apache.REEF.Common/Api/AbstractFailure.cs
@@ -101,7 +101,7 @@ namespace Org.Apache.REEF.Common.Api
/// <summary>
/// Identifier of the entity that produced the error. Cannot be null.
/// </summary>
- public string Id { get; set; }
+ public string Id { get; private set; }
public string Message { get; set; }
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Common/Exceptions/EvaluatorException.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Common/Exceptions/EvaluatorException.cs b/lang/cs/Org.Apache.REEF.Common/Exceptions/EvaluatorException.cs
index 9cb207a..319b4f2 100644
--- a/lang/cs/Org.Apache.REEF.Common/Exceptions/EvaluatorException.cs
+++ b/lang/cs/Org.Apache.REEF.Common/Exceptions/EvaluatorException.cs
@@ -69,7 +69,6 @@ namespace Org.Apache.REEF.Common.Exceptions
public string Id
{
get { return _evaluatorId; }
- set { }
}
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Common/Exceptions/JobException.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Common/Exceptions/JobException.cs b/lang/cs/Org.Apache.REEF.Common/Exceptions/JobException.cs
index 643cd76..8675be3 100644
--- a/lang/cs/Org.Apache.REEF.Common/Exceptions/JobException.cs
+++ b/lang/cs/Org.Apache.REEF.Common/Exceptions/JobException.cs
@@ -52,7 +52,6 @@ namespace Org.Apache.REEF.Common.Exceptions
public string Id
{
get { return _jobId; }
- set { }
}
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ActiveContext.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ActiveContext.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ActiveContext.cs
index 917e95a..a5fe63b 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ActiveContext.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ActiveContext.cs
@@ -52,10 +52,6 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
{
return Clr2Java.GetId();
}
-
- set
- {
- }
}
public string EvaluatorId
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/AllocatedEvaluator.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/AllocatedEvaluator.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/AllocatedEvaluator.cs
index c14960f..f7889eb 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/AllocatedEvaluator.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/AllocatedEvaluator.cs
@@ -62,7 +62,7 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
[DataMember]
public string InstanceId { get; set; }
- public string Id { get; set; }
+ public string Id { get; private set; }
public string EvaluatorBatchId { get; set; }
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ClosedContext.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ClosedContext.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ClosedContext.cs
index 4b81c6c..2aca0d2 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ClosedContext.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ClosedContext.cs
@@ -48,10 +48,6 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
{
return _id;
}
-
- set
- {
- }
}
public string EvaluatorId
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedEvaluator.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedEvaluator.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedEvaluator.cs
index 096599a..e38bb75 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedEvaluator.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedEvaluator.cs
@@ -49,10 +49,6 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
{
return CompletedEvaluatorClr2Java.GetId();
}
-
- set
- {
- }
}
[DataMember]
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedTask.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedTask.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedTask.cs
index 3fb76b2..6617b97 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedTask.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/CompletedTask.cs
@@ -49,10 +49,6 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
{
return CompletedTaskClr2Java.GetId();
}
-
- set
- {
- }
}
public IActiveContext ActiveContext
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ContextMessage.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ContextMessage.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ContextMessage.cs
index afebc59..d776bf7 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ContextMessage.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/ContextMessage.cs
@@ -38,7 +38,6 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
public string Id
{
get { return _id; }
- set { }
}
public string MessageSourceId
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedContext.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedContext.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedContext.cs
index f3bd4ba..0fe8819 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedContext.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedContext.cs
@@ -46,10 +46,6 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
{
return _id;
}
-
- set
- {
- }
}
public string EvaluatorId
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedEvaluator.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedEvaluator.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedEvaluator.cs
index a63f953..4feec3f 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedEvaluator.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedEvaluator.cs
@@ -46,7 +46,7 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
[DataMember]
public string InstanceId { get; set; }
- public string Id { get; set; }
+ public string Id { get; private set; }
public EvaluatorException EvaluatorException { get; set; }
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedTask.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedTask.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedTask.cs
index 119ec98..28be1af 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedTask.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/FailedTask.cs
@@ -46,7 +46,7 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
[DataMember]
public string InstanceId { get; set; }
- public string Id { get; set; }
+ public string Id { get; private set; }
public string Message { get; set; }
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/RunningTask.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/RunningTask.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/RunningTask.cs
index 12e59d1..b6f6a5c 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/RunningTask.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/RunningTask.cs
@@ -58,11 +58,6 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
{
return _runningTaskClr2Java.GetId();
}
-
- set
- {
- Id = value;
- }
}
public void Send(byte[] message)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/SuspendedTask.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/SuspendedTask.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/SuspendedTask.cs
index a694289..3a9415c 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/SuspendedTask.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/Events/SuspendedTask.cs
@@ -56,10 +56,6 @@ namespace Org.Apache.REEF.Driver.Bridge.Events
{
return SuspendedTaskClr2Java.GetId();
}
-
- set
- {
- }
}
public IActiveContext ActiveContext
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/02156e86/lang/cs/Org.Apache.REEF.Utilities/IIdentifiable.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Utilities/IIdentifiable.cs b/lang/cs/Org.Apache.REEF.Utilities/IIdentifiable.cs
index 532349c..a6c2e34 100644
--- a/lang/cs/Org.Apache.REEF.Utilities/IIdentifiable.cs
+++ b/lang/cs/Org.Apache.REEF.Utilities/IIdentifiable.cs
@@ -19,8 +19,14 @@
namespace Org.Apache.REEF.Utilities
{
+ /// <summary>
+ /// Denotes an object that has a string identifier.
+ /// </summary>
public interface IIdentifiable
{
- string Id { get; set; }
+ /// <summary>
+ /// The Id of this object, e.g. the TaskId.
+ /// </summary>
+ string Id { get;}
}
}
\ No newline at end of file