You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/16 16:53:03 UTC
[GitHub] [beam] vchunikhin opened a new pull request, #22310: [Playground][Backend][Bug]: Moving the initialization of properties file
vchunikhin opened a new pull request, #22310:
URL: https://github.com/apache/beam/pull/22310
fixes #22309
@VladMatyunin
Since Sdk_SDK_UNSPECIFIED in charge of datastore interaction, the properties file is needed only for this sdk
Otherwise, will be the next error for other SDKs like that:
```
│panic: Config File "properties" Not Found in "[/]"
│
│goroutine 1 [running]:
│main.main()
│ /go/src/playground/backend/cmd/server/server.go:203 +0x33
```
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22310: [Playground][Backend][Bug]: Moving the initialization of properties file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22310:
URL: https://github.com/apache/beam/pull/22310#issuecomment-1191118551
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #22310: [Playground][Backend][Bug]: Moving the initialization of properties file
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #22310:
URL: https://github.com/apache/beam/pull/22310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #22310: [Playground][Backend][Bug]: Moving the initialization of properties file
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22310:
URL: https://github.com/apache/beam/pull/22310#issuecomment-1208369742
lgtm thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] vchunikhin commented on a diff in pull request #22310: [Playground][Backend][Bug]: Moving the initialization of properties file
Posted by GitBox <gi...@apache.org>.
vchunikhin commented on code in PR #22310:
URL: https://github.com/apache/beam/pull/22310#discussion_r926321190
##########
playground/backend/containers/go/Dockerfile:
##########
@@ -55,6 +55,7 @@ ENV SERVER_PORT=8080
ENV APP_WORK_DIR=/opt/playground/backend/
ENV BEAM_SDK="SDK_GO"
ENV BUCKET_NAME="playground-precompiled-objects"
+ENV PROPERTY_PATH=/opt/playground/backend/properties.yaml
Review Comment:
PROPERTY_PATH was added for every docker file to avoid problems when we will use properties.yaml for runners (JAVA, PYTHON, SCIO, GO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] vchunikhin commented on pull request #22310: [Playground][Backend][Bug]: Moving the initialization of properties file
Posted by GitBox <gi...@apache.org>.
vchunikhin commented on PR #22310:
URL: https://github.com/apache/beam/pull/22310#issuecomment-1191117591
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org