You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/23 19:35:23 UTC

[GitHub] [druid] harshpreet93 commented on pull request #10059: retry 500 and 503 errors against kinesis

harshpreet93 commented on pull request #10059:
URL: https://github.com/apache/druid/pull/10059#issuecomment-648374960


   > LGTM, thanks for the fix!
   
   thanks @jon-wei , it looks like the code at https://github.com/apache/druid/blob/master/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java#L802-L812 can also use the same treatment since it's also calling getRecords and it only retries ProvisionedThroughputExceededException, but all 500 and 503 errors should be retried there as well right? Should I put a fix to that in a follow up PR or attach it to this one?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org