[GitHub] [superset] michael-s-molina commented on issue #14383: [SIP-64] Migrate filter_box to Dashboard Native Filter Component

[GitBox <gi...@apache.org>]

michael-s-molina commented on issue #14383:
URL: https://github.com/apache/superset/issues/14383#issuecomment-924336183


   @graceguo-supercat If in the end, we’ll have a back-end migration script that converts a filter box configuration into a native filter configuration, why don’t we skip the part of creating the same logic on the front-end and just do it on the back-end? We can add to each automatically converted filter the status of approved or rejected (which will hide the filter) and offer an option to the owner to set this status on the interface. Something like this:
   
   <img width="1786" alt="Screen Shot 2021-09-21 at 4 45 01 PM" src="https://user-images.githubusercontent.com/70410625/134237864-154a4a9b-48f4-4ab4-9f93-ea8698750974.png">
   
   This way we can monitor rejected filters, migration completion, and the owner can save his dashboard without worrying about side effects. Only accepted filters will appear to non-owner users. This workflow also works for users that already have native filters created.
   
   The owner can have both filter boxes and native filters at the same time for validation, and when it is validated, he can remove the filter box from the dashboard or we can do it on a pre-defined date. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org