You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Joe Swatosh <jo...@gmail.com> on 2007/04/22 21:31:18 UTC

[patch] Make definition of AOFF2NUM complete at compile time for swigutil_rb.c

I'm trying to reduce the noise when building the Ruby bindings.  So I
don't get too used to so many warnings.

[[[
Deal with compiler warning for (possible) narrowing conversion

* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
 Make the definition of AOFF2NUM complete at preprocessor time instead of
 run time.
]]]

Index: subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
===================================================================
--- subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c	(revision
24695)
+++ subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c	(working copy)
@@ -38,8 +38,11 @@
 #include "svn_utf.h"


-#define AOFF2NUM(num) \
-  (sizeof(apr_off_t) == SIZEOF_LONG_LONG ? LL2NUM(num) : LONG2NUM(num))
+#if APR_HAS_LARGE_FILES
+#  define AOFF2NUM(num) LL2NUM(num)
+#else
+#  define AOFF2NUM(num) LONG2NUM(num)
+#endif

 #if SIZEOF_LONG_LONG == 8
 #  define AI642NUM(num) LL2NUM(num)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [patch] Make definition of AOFF2NUM complete at compile time for swigutil_rb.c

Posted by Joe Swatosh <jo...@gmail.com>.
On 4/23/07, Daniel Rall <dl...@collab.net> wrote:
> On Sun, 22 Apr 2007, Joe Swatosh wrote:
>
> > I'm trying to reduce the noise when building the Ruby bindings.  So I
> > don't get too used to so many warnings.
> >
> > [[[
> > Deal with compiler warning for (possible) narrowing conversion
> >
> > * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> > Make the definition of AOFF2NUM complete at preprocessor time instead of
> > run time.
> > ]]]
>
> +1
>
>

r24727

Thanks,
--
Joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [patch] Make definition of AOFF2NUM complete at compile time for swigutil_rb.c

Posted by Daniel Rall <dl...@collab.net>.
On Sun, 22 Apr 2007, Joe Swatosh wrote:

> I'm trying to reduce the noise when building the Ruby bindings.  So I
> don't get too used to so many warnings.
> 
> [[[
> Deal with compiler warning for (possible) narrowing conversion
> 
> * subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c
> Make the definition of AOFF2NUM complete at preprocessor time instead of
> run time.
> ]]]
 
+1