You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/16 09:46:47 UTC
[GitHub] [spark] leanken opened a new pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
leanken opened a new pull request #30386:
URL: https://github.com/apache/spark/pull/30386
### What changes were proposed in this pull request?
Instead of returning NULL, throws runtime NoSuchElementException towards invalid key accessing in map-like functions, such as element_at, GetMapValue, when ANSI mode is on.
### Why are the changes needed?
For ANSI mode.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Added UT and Existing UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728108704
**[Test build #131150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131150/testReport)** for PR 30386 at commit [`2649359`](https://github.com/apache/spark/commit/26493599845eaf0fa16375fb41039cd3e2b9ebe0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727916010
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35753/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727915983
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35753/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727898009
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35753/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728105138
**[Test build #131165 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131165/testReport)** for PR 30386 at commit [`9e29957`](https://github.com/apache/spark/commit/9e299570a97fce7b90684aea957ac60cb7a6d8f5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727895676
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35752/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728114194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728151240
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35768/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728131419
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35768/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728110241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728110253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728151266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35768/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728151256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727867786
**[Test build #131149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131149/testReport)** for PR 30386 at commit [`d830d14`](https://github.com/apache/spark/commit/d830d14ab681597c29661bb114e74f06e36d8412).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727916000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727908096
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35752/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727872078
**[Test build #131150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131150/testReport)** for PR 30386 at commit [`2649359`](https://github.com/apache/spark/commit/26493599845eaf0fa16375fb41039cd3e2b9ebe0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727872078
**[Test build #131150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131150/testReport)** for PR 30386 at commit [`2649359`](https://github.com/apache/spark/commit/26493599845eaf0fa16375fb41039cd3e2b9ebe0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728278125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728277078
**[Test build #131165 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131165/testReport)** for PR 30386 at commit [`9e29957`](https://github.com/apache/spark/commit/9e299570a97fce7b90684aea957ac60cb7a6d8f5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30386:
URL: https://github.com/apache/spark/pull/30386#discussion_r524280730
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -352,14 +357,25 @@ trait GetMapValueUtil extends BinaryExpression with ImplicitCastInputTypes {
}
}
- if (!found || values.isNullAt(i)) {
+ if (!found) {
+ if (failOnError) {
+ throw new NoSuchElementException(s"Key $ordinal does not exist.")
+ } else {
+ null
+ }
+ }
+ else if (values.isNullAt(i)) {
Review comment:
nit: merge it to the previous line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728114194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728278125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727916000
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728105138
**[Test build #131165 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131165/testReport)** for PR 30386 at commit [`9e29957`](https://github.com/apache/spark/commit/9e299570a97fce7b90684aea957ac60cb7a6d8f5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728151256
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728112061
**[Test build #131149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131149/testReport)** for PR 30386 at commit [`d830d14`](https://github.com/apache/spark/commit/d830d14ab681597c29661bb114e74f06e36d8412).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class GetMapValue(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727908131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727867786
**[Test build #131149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131149/testReport)** for PR 30386 at commit [`d830d14`](https://github.com/apache/spark/commit/d830d14ab681597c29661bb114e74f06e36d8412).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30386:
URL: https://github.com/apache/spark/pull/30386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] leanken commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
leanken commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727864836
@cloud-fan FYI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-727908131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30386: [SPARK-33460][SQL] Accessing map values should fail if key is not found
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30386:
URL: https://github.com/apache/spark/pull/30386#issuecomment-728163345
GA passed, merging to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org