[GitHub] [iceberg] wypoon commented on pull request #1508: Use schema at the time of the snapshot when reading a snapshot.

[GitBox <gi...@apache.org>]

wypoon commented on pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#issuecomment-879465155


   @yyanyy I have updated this since #2275 was merged. Can you please review it?
   In `BaseTable#schemaForSnapshot`, we look up the schema by `schema-id` from the `schemas` list. If it is not found, we go through the previous metadata files until we find one whose current snapshot id is the snapshot id and get the schema from there.
   The rest of the PR basically supports using the schema for the snapshot when reading an Iceberg table from Spark. I am not qualified to make the changes for other engines (I don't believe Hive supports time travel yet), so that can be done by others in separate PRs.
   @rdblue, @RussellSpitzer, @aokolnychyi , can any of you help review this too? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org