You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by DLotts <gi...@git.apache.org> on 2017/09/08 14:03:30 UTC
[GitHub] incubator-rya pull request #224: [WIP] RYA-361 Remove JCalendar library from...
GitHub user DLotts opened a pull request:
https://github.com/apache/incubator-rya/pull/224
[WIP] RYA-361 Remove JCalendar library from merge/copy/export
## Description
Removed JCalendar and entire dialog prompt feature from options settings and poms.
This library is LGPL, not allowed in an Apache project.
### Tests
Removed dialog references, no new tests
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-361)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
#### People To Review
- Eric
- anyone
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DLotts/incubator-rya RYA-361-JCalendar-rm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit ea3a75835c8b63b24669db6f185aef1e14230ea0
Author: David Lotts <da...@parsons.com>
Date: 2017-09-07T21:23:52Z
rya361 wip. todo: remove test references to dialog.
commit 508e7f2159d87526bfdf76099549e8aab4122c67
Author: David Lotts <da...@parsons.com>
Date: 2017-09-08T13:57:07Z
rya361 wip. todo: tests failing.
----
---
[GitHub] incubator-rya issue #224: RYA-361 Remove JCalendar library from merge/copy/e...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/224
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/479/
---
[GitHub] incubator-rya issue #224: RYA-361 Remove JCalendar library from merge/copy/e...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/224
asfbot build
---
[GitHub] incubator-rya issue #224: [WIP] RYA-361 Remove JCalendar library from merge/...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/224
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/476/
---
[GitHub] incubator-rya issue #224: [WIP] RYA-361 Remove JCalendar library from merge/...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/224
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/<h2>Failed Tests: <span class='status-failure'>8</span></h2><h3><a name='incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.merger' /><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport'>incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.merger</a>: <span class='status-failure'>8</span></h3><ul><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport/org.apache.rya.accumulo.mr.merge/CopyToolTest/testCopyTool/'><strong>org.apache.rya.accumulo.mr.merge.CopyToolTest.testCopyTool</strong></a></li><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport/org.apache.rya.accumulo.mr.merge/MergeToolTest/testMergeTool/'><strong>org.apache.rya.a
ccumulo.mr.merge.MergeToolTest.testMergeTool</strong></a></li><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport/org.apache.rya.accumulo.mr.merge/MergeToolTest/testNewParentEmptyChild/'><strong>org.apache.rya.accumulo.mr.merge.MergeToolTest.testNewParentEmptyChild</strong></a></li><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport/org.apache.rya.accumulo.mr.merge/MergeToolTest/testNewParentMissingChild/'><strong>org.apache.rya.accumulo.mr.merge.MergeToolTest.testNewParentMissingChild</strong></a></li><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport/org.apache.rya.accumulo.mr.merge/MergeToolTest/testWithDefaultSplits/'><strong>org.apache.rya.accumulo.mr.merge.MergeToolTest.testWithDefaultSplits</strong></a></li><li><a href='https://build
s.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport/org.apache.rya.accumulo.mr.merge/MergeToolTest/testWithParentSplits/'><strong>org.apache.rya.accumulo.mr.merge.MergeToolTest.testWithParentSplits</strong></a></li><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport/org.apache.rya.accumulo.mr.merge/MergeToolTest/testWithChildSplits/'><strong>org.apache.rya.accumulo.mr.merge.MergeToolTest.testWithChildSplits</strong></a></li><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/475/org.apache.rya$rya.merger/testReport/org.apache.rya.accumulo.mr.merge/MergeToolTest/testWithParentAndChildSplits/'><strong>org.apache.rya.accumulo.mr.merge.MergeToolTest.testWithParentAndChildSplits</strong></a></li></ul>
---
[GitHub] incubator-rya pull request #224: RYA-361 Remove JCalendar library from merge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/224
---
[GitHub] incubator-rya pull request #224: RYA-361 Remove JCalendar library from merge...
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/224#discussion_r137833944
--- Diff: extras/rya.export/export.client/src/main/java/org/apache/rya/export/client/conf/MergeConfigurationCLI.java ---
@@ -149,7 +145,12 @@ public static MergeToolConfiguration createConfigurationFromFile(final File conf
throw new MergeConfigurationException("Failed to create a config based on the provided configuration.", JAXBe);
}
}
-
+ /**
+ * returns the time option and makes it required.
+ * This is for API and is not used internally as of v3.2.11
+ * @return
--- End diff --
Add description to return and throws. Make it clear that it returns a time or throws an exception when no time is configured because time is required.
---
[GitHub] incubator-rya issue #224: RYA-361 Remove JCalendar library from merge/copy/e...
Posted by DLotts <gi...@git.apache.org>.
Github user DLotts commented on the issue:
https://github.com/apache/incubator-rya/pull/224
asfbot build
---
[GitHub] incubator-rya issue #224: [WIP] RYA-361 Remove JCalendar library from merge/...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/224
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/477/<h2>Failed Tests: <span class='status-failure'>3</span></h2><h3><a name='incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.prospector' /><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/477/org.apache.rya$rya.prospector/testReport'>incubator-rya-master-with-optionals-pull-requests/org.apache.rya:rya.prospector</a>: <span class='status-failure'>3</span></h3><ul><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/477/org.apache.rya$rya.prospector/testReport/org.apache.rya.prospector.mr/ProspectorTest/testCount/'><strong>org.apache.rya.prospector.mr.ProspectorTest.testCount</strong></a></li><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/477/org.apache.rya$rya.prospector/testReport/org.apache.rya.prospector.service/ProspectorServiceEvalStatsDAOTest/testCount
/'><strong>org.apache.rya.prospector.service.ProspectorServiceEvalStatsDAOTest.testCount</strong></a></li><li><a href='https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/477/org.apache.rya$rya.prospector/testReport/org.apache.rya.prospector.service/ProspectorServiceEvalStatsDAOTest/testNoAuthsCount/'><strong>org.apache.rya.prospector.service.ProspectorServiceEvalStatsDAOTest.testNoAuthsCount</strong></a></li></ul>
---
[GitHub] incubator-rya issue #224: RYA-361 Remove JCalendar library from merge/copy/e...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/224
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/478/
---