You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/08/19 01:33:47 UTC

Review Request 24823: Use convenience function in Numbers to group instance IDs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24823/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
-------

Only realized after review that i had written very similar code once before :-)


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java f21f27cdce457c7bc09670a68a865159daff5559 

Diff: https://reviews.apache.org/r/24823/diff/


Testing
-------

./gradlew build -Pq


Thanks,

Bill Farner


Re: Review Request 24823: Use convenience function in Numbers to group instance IDs.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24823/#review50941
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Aug. 18, 2014, 11:33 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24823/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 11:33 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Only realized after review that i had written very similar code once before :-)
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java f21f27cdce457c7bc09670a68a865159daff5559 
> 
> Diff: https://reviews.apache.org/r/24823/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>