You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "AnandInguva (via GitHub)" <gi...@apache.org> on 2023/08/01 12:35:20 UTC

[GitHub] [beam] AnandInguva commented on pull request #27621: Remove unused `reverse` argument in SmallestPerKey

AnandInguva commented on PR #27621:
URL: https://github.com/apache/beam/pull/27621#issuecomment-1660226892

   I would leave it like this if it can be a breaking change. We also have a `use_fastavro` https://github.com/apache/beam/blob/ab93fb1988051baac6c3b9dd1031f4d68bd9a149/sdks/python/apache_beam/io/avroio.py#L141 which is not used anymore but it was not removed for backwards compatibility. May be add a deprecated warning for 2.50.0 and remove it in 2.51.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org