[GitHub] [flink] xintongsong commented on a diff in pull request #22119: [FLINK-31321][Deployment/YARN] Yarn-session mode, securityConfiguration supports dynamic configuration

["xintongsong (via GitHub)" <gi...@apache.org>]

xintongsong commented on code in PR #22119:
URL: https://github.com/apache/flink/pull/22119#discussion_r1130666576


##########
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java:
##########
@@ -853,6 +855,9 @@ public static void main(final String[] args) {
                             "",
                             ""); // no prefix for the YARN session
 
+            final CommandLine commandLine = CliFrontendParser.parse(cli.allOptions, args, true);
+            DynamicPropertiesUtil.encodeDynamicProperties(commandLine, flinkConfiguration);

Review Comment:
   This also changes the configuration that has already been passed into `FlinkYarnSessionCli`. I'm not entirely sure about the impact. Maybe it's safer to clone the configuration before modifying it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org