You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/10/28 06:51:07 UTC
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/992
[master/4.6] CLOUDSTACK-9000: logrotate cloudstack-agent out and err logs
Adds logrotate rules for cloudstack-agent.{err,out}, jsvc err/out log files may fill up disk. This adds a logrotate config in the rpm packages
cc @remibergsma @wido @wilderrodrigues and others
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack master-logrotate-kvm-agent-erroutlogs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #992
----
commit c6bfa051c7f247ba612801371f9ce2f8db6b04aa
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2015-10-28T05:44:49Z
CLOUDSTACK-9000: logrotate cloudstack-agent out and err logs
Adds logrotate rules for cloudstack-agent.{err,out} log files
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151812042
@bhaisaab Maybe you can force push again, because it failed (https://builds.apache.org/job/cloudstack-pull-analysis/1031/). probably not related to what you did, but still nice to see it pass.
Will build some packages and test this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151806586
@remibergsma Jenkins seems quite happy - https://builds.apache.org/job/cloudstack-pull-analysis/1026/ ?
See this rpm build (4.5 actually) - http://sb.bhaisaab.org:8888/job/rpm-shapeblue-build-patch-noredist/100/console or rpms: http://sb.bhaisaab.org/cloudstack/kvmagentrot/centos/4.5-logrotate-kvm-agent-erroutlogs/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-152082434
@wido @wilderrodrigues @borisroman reviews please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-152476140
@remibergsma should we merge this on master now? (jenkins failed due to some jvm issue)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151805630
@bhaisaab Thanks, can you please make Jenkins happy? ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/992
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-152134450
LGTM now DEB is included
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151896039
Thanks @remibergsma the jenkins build still failed due to JVM crashing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151778449
Why only RPM and not for DEB?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151816807
@remibergsma looks like JVM crashed - https://builds.apache.org/job/cloudstack-pull-analysis/1031/org.apache.cloudstack$cloud-server/console
forcing pushing again to kick another job
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151836687
LGTM, tested on `CentOS 7` and the logrotate file gets properly installed:
```
[root@kvm1 logrotate.d]# pwd
/etc/logrotate.d
[root@kvm1 logrotate.d]# cat cloudstack-agent
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
/var/log/cloudstack/agent/cloudstack-agent.out
/var/log/cloudstack/agent/cloudstack-agent.err
{
copytruncate
daily
rotate 5
compress
missingok
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-151790553
@wido fixed now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/992#issuecomment-152486552
Double checked a compile:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:57.299s
[INFO] Finished at: Fri Oct 30 10:21:07 GMT 2015
[INFO] Final Memory: 84M/417M
[INFO] ------------------------------------------------------------------------
+ exit 0
```
Will soon merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---