[jira] Updated: (SCM-68) Subversion provider doesn't handle tag updates correctly

["David Hawkins (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/SCM-68?page=all ]

David Hawkins updated SCM-68:
-----------------------------

    Attachment: update-switch-revised.patch

I found another issue regarding tags and "" empty/whitespace tags and corrected it. By doing this I did slightly change the functionality of the tag feature in that the original behavior was to issue an "svn update -r" with no revision specified if executeCommand() was provided an empty string for tag.  This is not valid syntax for the svn command as issuing an "update -r" without specifying any value for "r" yields:
$ svn up -r
svn: missing argument: r
Type 'svn help' for usage.

So the update command now treats "" empty strings as null and no longer issues empty -r arguments.  The test case was updated to reflect this.  I also added additional test cases for the tag resolution routines.

--David


> Subversion provider doesn't handle tag updates correctly
> --------------------------------------------------------
>
>          Key: SCM-68
>          URL: http://jira.codehaus.org/browse/SCM-68
>      Project: Maven SCM
>         Type: Bug
>   Components: maven-scm-provider-svn
>     Versions: 1.0-alpha-4
>     Reporter: David Hawkins
>  Attachments: update-switch-revised.patch, update-switch.patch
>
>
> When attempting to use Continuum I kept having problems where Continuum would checkout the project fine, but always fail to update it on subsequent builds.  Continuum forces you to specify a scmTagBase as well as a scmTag for subversion projects.  The problem is that is passes the tag to the scm update which ends up issuing a svn command with -r tagname 
> Example:
>     checkout command:
>         svn --non-interactive checkout http://svn/projects/dmi-jdbc/branches/my-branch-name 6
>     update command
>         svn --non-interactive update -r branches/my-branch-name
> This probably works fine in cvs because a tag can refer to a revision or tag.  In subversion, tags and revisions are obviously very different so the SvnUpdateCommand should handle the two cases differently if you are requesting a revision or an actual tag.
> I've created a patch which corrects  the problem and causes SvnUpdateCommand to perform a switch to update whenever a non revision tag is specified.  I believe this will produce the intended results, but I am also fairly new to subversion and its possible it doesn't.
> Please let me know if you need more information.
> --David

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira