You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/29 01:28:10 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request, #15378: [PIP-159][Improve][txn]Reuse transaction buffer reader
liangyepianzhou opened a new pull request, #15378:
URL: https://github.com/apache/pulsar/pull/15378
### Motivation & Modification
Details can be found in https://github.com/apache/pulsar/issues/15334
test have been covered by TopicTransactionBufferRecoverTest.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-added`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15378: [PIP-159][Improve][txn]Reuse transaction buffer reader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15378:
URL: https://github.com/apache/pulsar/pull/15378#issuecomment-1140610299
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #15378: [PIP-159][Improve][txn]Reuse transaction buffer reader
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on PR #15378:
URL: https://github.com/apache/pulsar/pull/15378#issuecomment-1327965980
Run a standalone, and use the below test to get the running time of change thread or not.
```java
public void testTheRateOfExternalEcutorService() throws Exception {
String topic = "testTheRateOfExternalEcutorService";
String subName = "subName";
int message_total = 1000;
ExecutorService executorService = Executors.newFixedThreadPool(10);
pulsarClient = PulsarClient.builder().serviceUrl("pulsar://127.0.0.1:6650").enableTransaction(true).build();
((PulsarClientImpl) pulsarClient).testExecutorService = executorService;
//Build producer and consumer
@Cleanup
Producer<String> producer = pulsarClient.newProducer(Schema.STRING)
.topic(topic)
.create();
@Cleanup
Consumer<String> consumer = pulsarClient.newConsumer(Schema.STRING)
.topic(topic)
.subscriptionName(subName)
.subscribe();
CountDownLatch countDownLatch = new CountDownLatch(message_total);
for (int i = 0; i < message_total; i++) {
producer.newMessage().send();
}
long start_time = System.currentTimeMillis();
for (int i = 0; i < message_total; i++) {
pulsarClient.newTransaction().build().thenAcceptAsync(txn -> {
try {
producer.newMessage(txn).sendAsync();
Message<String> message = consumer.receive(3, TimeUnit.SECONDS);
consumer.acknowledgeAsync(message.getMessageId(), txn);
txn.commit().thenRun(countDownLatch::countDown);
} catch (Exception e) {
throw new RuntimeException(e);
}
});
}
countDownLatch.await();
long end_time = System.currentTimeMillis();
log.info("The message process by external executor test spend {} millis",
TimeUnit.MILLISECONDS.toMillis(end_time - start_time));
}
```
* The original process rate
- The message process test spends 708 millis thread
* The process rate of change thread, there. is not needed to use a single thread, so the rate changes by the thread size
- The message process by external executor test spends 782 millis (thread size = 1)
- The message process by external executor test spends 727 millis (thread size = 5)
- The message process by external executor test spends 344 millis (thread size = 10)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou closed pull request #15378: [PIP-159][Improve][txn]Reuse transaction buffer reader
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou closed pull request #15378: [PIP-159][Improve][txn]Reuse transaction buffer reader
URL: https://github.com/apache/pulsar/pull/15378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org