Re:

[hx...@cloudera.com]

Could you elaborate? What do you mean by two different p5? Can I rm the old p5 in toolchain directory and build again?

Or do you mean the problem is in the s3?

Sorry for bothering your pto. :)



> On May 21, 2016, at 8:14 AM, Henry Robinson <he...@cloudera.com> wrote:
> 
> Thanks for taking care of the p5 issue. However, this could lead to having two different p5 builds out there. Suggest instead combining a revert for p5 and your new patch into p6. 
> 
> Henry
> 
> 
>> On May 20, 2016, at 11:29 PM, Huaisi Xu (Code Review) <ge...@cloudera.org> wrote:
>> 
>> Huaisi Xu has uploaded a new patch set (#3).
>> 
>> Change subject: IMPALA-3494: Fix Thrift TMemoryBuffer overflow
>> ......................................................................
>> 
>> IMPALA-3494: Fix Thrift TMemoryBuffer overflow
>> 
>> Also include THRIFT-1248: fix TMemoryBuffer pointer arithmetic
>> 
>> Change-Id: I91086ed9d0b4f95b5532de67fe35b46b748ad16c
>> ---
>> M buildall.sh
>> A source/thrift/thrift-0.9.0-patches/0005-IMPALA-3494-fix-Thrift-TMemoryBuffer-overflow.patch
>> R source/thrift/thrift-0.9.0-patches/0006-IMPALA-3159-Add-SAN-Wildcard-SSL-cert-client-support-in-python.patch
>> 3 files changed, 39 insertions(+), 0 deletions(-)
>> 
>> 
>> git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/49/3149/3
>> -- 
>> To view, visit http://gerrit.cloudera.org:8080/3149
>> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>> 
>> Gerrit-MessageType: newpatchset
>> Gerrit-Change-Id: I91086ed9d0b4f95b5532de67fe35b46b748ad16c
>> Gerrit-PatchSet: 3
>> Gerrit-Project: Toolchain
>> Gerrit-Branch: master
>> Gerrit-Owner: Huaisi Xu <hx...@cloudera.com>
>> Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
>> Gerrit-Reviewer: Huaisi Xu <hx...@cloudera.com>
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups "impala-cr" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to impala-cr+unsubscribe@cloudera.com.
>> For more options, visit https://groups.google.com/a/cloudera.com/d/optout.