You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2019/05/09 06:32:58 UTC
[wicket] 05/11: JS removed Wicket.Browser.isSafari()
This is an automated email from the ASF dual-hosted git repository.
svenmeier pushed a commit to branch wicket-js-cleanup
in repository https://gitbox.apache.org/repos/asf/wicket.git
commit ef121c5c6ccc6d3dd31b117b9152723fe990a22a
Author: Sven Meier <sv...@apache.org>
AuthorDate: Mon May 6 14:49:12 2019 +0200
JS removed Wicket.Browser.isSafari()
was used in wicket-autocomplete.js for obscure reasons
---
.../wicket/ajax/res/js/wicket-ajax-jquery.js | 26 ++--------------------
.../html/autocomplete/wicket-autocomplete.js | 6 -----
2 files changed, 2 insertions(+), 30 deletions(-)
diff --git a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
index dc52310..c20b86a 100644
--- a/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
+++ b/wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
@@ -36,19 +36,6 @@
return;
}
- /**
- * Add a check for old Safari. It should not be our responsibility to check the
- * browser's version, but it's a minor version that makes a difference here,
- * so we try to be at least user friendly.
- */
- if (typeof(DOMParser) === "undefined" && Wicket.Browser.isSafari()) {
- DOMParser = function () {};
-
- DOMParser.prototype.parseFromString = function () {
- window.alert('You are using an old version of Safari.\nTo be able to use this page you need at least version 2.0.1.');
- };
- }
-
var getAjaxBaseUrl,
isUndef,
replaceAll,
@@ -2467,15 +2454,6 @@
jQuery.extend(true, Wicket, {
Browser: {
- _isSafari: null,
- isSafari: function () {
- var wb = Wicket.Browser;
- if (wb._isSafari === null) {
- wb._isSafari = !/Chrome/.test(window.navigator.userAgent) && /KHTML/.test(window.navigator.userAgent) && /Apple/.test(window.navigator.userAgent);
- }
- return wb._isSafari;
- },
-
_isChrome: null,
isChrome: function () {
var wb = Wicket.Browser;
@@ -2489,7 +2467,7 @@
isIE: function () {
var wb = Wicket.Browser;
if (wb._isIE === null) {
- wb._isIE = !Wicket.Browser.isSafari() && (typeof(document.all) !== "undefined" || window.navigator.userAgent.indexOf("Trident/")>-1) && typeof(window.opera) === "undefined";
+ wb._isIE = (typeof(document.all) !== "undefined" || window.navigator.userAgent.indexOf("Trident/")>-1) && typeof(window.opera) === "undefined";
}
return wb._isIE;
},
@@ -2519,7 +2497,7 @@
isIELessThan11: function () {
var wb = Wicket.Browser;
if (wb._isIELessThan11 === null) {
- wb._isIELessThan11 = !Wicket.Browser.isSafari() && typeof(document.all) !== "undefined" && typeof(window.opera) === "undefined";
+ wb._isIELessThan11 = typeof(document.all) !== "undefined" && typeof(window.opera) === "undefined";
}
return wb._isIELessThan11;
},
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
index 26f4b8d..2610beb 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
@@ -128,9 +128,6 @@
}
render(true, false);
- if (Wicket.Browser.isSafari()) {
- return jqEvent.stopPropagation();
- }
break;
case KEY_DOWN:
if (selected < elementCount-1) {
@@ -145,9 +142,6 @@
render(true, false);
showAutoComplete();
}
- if (Wicket.Browser.isSafari()) {
- return jqEvent.stopPropagation();
- }
break;
case KEY_ESC:
if (visible === 1) {