You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/01/27 01:48:51 UTC
Review Request 30297: Used Clock instead of Stopwatch in limiter
tests for reliablity.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
Used Clock instead of Stopwatch in limiter tests for reliablity.
Diffs
-----
3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/30297/diff/
Testing
-------
Ran the limiter tests 100 times
Thanks,
Vinod Kone
Re: Review Request 30297: Used Clock instead of Stopwatch in limiter
tests for reliablity.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/#review69738
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30191, 30192, 30297]
All tests passed.
- Mesos ReviewBot
On Jan. 27, 2015, 12:48 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30297/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 12:48 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used Clock instead of Stopwatch in limiter tests for reliablity.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30297/diff/
>
>
> Testing
> -------
>
> Ran the limiter tests 100 times
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 30297: Used Clock instead of Stopwatch in limiter
tests for reliablity.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/#review70099
-----------------------------------------------------------
Patch looks great!
Reviews applied: [30348, 30191, 30192, 30297]
All tests passed.
- Mesos ReviewBot
On Jan. 28, 2015, 10 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30297/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2015, 10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used Clock instead of Stopwatch in limiter tests for reliablity.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30297/diff/
>
>
> Testing
> -------
>
> Ran the limiter tests 100 times
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 30297: Used Clock instead of Stopwatch in limiter
tests for reliablity.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/
-----------------------------------------------------------
(Updated Jan. 28, 2015, 10 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
jie's comments. NNFR.
Repository: mesos-git
Description
-------
Used Clock instead of Stopwatch in limiter tests for reliablity.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/30297/diff/
Testing
-------
Ran the limiter tests 100 times
Thanks,
Vinod Kone
Re: Review Request 30297: Used Clock instead of Stopwatch in limiter
tests for reliablity.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/#review70074
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/tests/limiter_tests.cpp
<https://reviews.apache.org/r/30297/#comment115037>
EXPECT_TRUE?
3rdparty/libprocess/src/tests/limiter_tests.cpp
<https://reviews.apache.org/r/30297/#comment115038>
Discard 'acquire2'.
- Jie Yu
On Jan. 27, 2015, 12:48 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30297/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 12:48 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used Clock instead of Stopwatch in limiter tests for reliablity.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30297/diff/
>
>
> Testing
> -------
>
> Ran the limiter tests 100 times
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 30297: Used Clock instead of Stopwatch in limiter
tests for reliablity.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/#review69763
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Jan. 27, 2015, 1:48 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30297/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2015, 1:48 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Used Clock instead of Stopwatch in limiter tests for reliablity.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/limiter_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/30297/diff/
>
>
> Testing
> -------
>
> Ran the limiter tests 100 times
>
>
> Thanks,
>
> Vinod Kone
>
>