You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "eubnara (via GitHub)" <gi...@apache.org> on 2025/11/13 01:45:48 UTC

[PR] AMBARI-26555: Password leaked for configurations at stack root (e.g. cluster-env.xml) [ambari]

eubnara opened a new pull request, #4086:
URL: https://github.com/apache/ambari/pull/4086

   
   
   ## What changes were proposed in this pull request?
   
   fix `StackInfo#getConfigPropertiesTypes()` to handle configurations on stack root properly.
   
   ## How was this patch tested?
   
   Manually tested on private cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-26555: Password leaked for configurations at stack root (e.g. cluster-env.xml) [ambari]

Posted by "eubnara (via GitHub)" <gi...@apache.org>.
eubnara commented on code in PR #4086:
URL: https://github.com/apache/ambari/pull/4086#discussion_r2520769863


##########
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java:
##########
@@ -513,27 +513,44 @@ public Map<String, PropertyInfo> getRequiredProperties() {
   }
 
   public Map<PropertyInfo.PropertyType, Set<String>> getConfigPropertiesTypes(String configType) {
-    if(!propertiesTypesCache.containsKey(configType)) {
+    if (!propertiesTypesCache.containsKey(configType)) {
       Map<PropertyInfo.PropertyType, Set<String>> propertiesTypes = new HashMap<>();
+
+      collectPropertyTypes(propertiesTypes, getProperties(), configType);

Review Comment:
   This line is need to properly add property types for configurations at stack root (e.g. cluster-env.xml).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org


Re: [PR] AMBARI-26555: Password leaked for configurations at stack root (e.g. cluster-env.xml) [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.
JiaLiangC merged PR #4086:
URL: https://github.com/apache/ambari/pull/4086


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org