You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 19:54:40 UTC
[GitHub] [airflow] dstandish opened a new pull request #15594: Put odbc import behind guard in MsSqlOperator
dstandish opened a new pull request #15594:
URL: https://github.com/apache/airflow/pull/15594
MsSqlOperator uses odbc hook when conn_type = 'odbc'
The import here of OdbcHook, used only for type hinting, should be behind `TYPE_CHECKING` guard
see: https://github.com/apache/airflow/pull/6850#issuecomment-829225488
@eladkal this may not address the CI issue you mentioned. please give me a link so i can understand what you're referring to.
it's possible we can decouple the tests too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish merged pull request #15594: Remove odbc dependency in microsoft.mssql provider
Posted by GitBox <gi...@apache.org>.
dstandish merged pull request #15594:
URL: https://github.com/apache/airflow/pull/15594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15594: Remove odbc dependency in microsoft.mssql provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15594:
URL: https://github.com/apache/airflow/pull/15594#issuecomment-829622626
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org