You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/11/06 09:00:22 UTC

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14643


Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................

[thirdparty] Bump sparsepp and sparsehash-c11 version

Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
---
M thirdparty/vars.sh
1 file changed, 2 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14643/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14643 )

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................

[thirdparty] Bump sparsepp and sparsehash-c11 version

Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Reviewed-on: http://gerrit.cloudera.org:8080/14643
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M thirdparty/vars.sh
1 file changed, 2 insertions(+), 9 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14643

to look at the new patch set (#2).

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................

[thirdparty] Bump sparsepp and sparsehash-c11 version

Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
---
M thirdparty/vars.sh
1 file changed, 2 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14643/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14643 )

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................


Patch Set 1:

Please help to upload these thirdparty libraries to https://d3dr9sfxru4sde.cloudfront.net, 

sparsehash-c11:
# Hash of the sparsehash-c11 git revision to use.
# (from http://github.com/sparsehash/sparsehash-c11)
#
# To re-build this tarball use the following in the sparsehash-c11 repo:
#  export NAME=sparsehash-c11-$(git rev-parse HEAD)
#  git archive HEAD --prefix=$NAME/ -o /tmp/$NAME.tar.gz
#  s3cmd put -P /tmp/$NAME.tar.gz s3://cloudera-thirdparty-libs/$NAME.tar.gz


sparsepp:
https://github.com/greg7mdp/sparsepp/archive/1.22.tar.gz


-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 09:07:29 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14643 )

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................


Patch Set 1:

Please help to upload these thirdparty libraries to https://d3dr9sfxru4sde.cloudfront.net, 

sparsehash-c11:
# Hash of the sparsehash-c11 git revision to use.
# (from http://github.com/sparsehash/sparsehash-c11)	# (from http://github.com/sparsehash/sparsehash-c11)
#	#
# To re-build this tarball use the following in the sparsehash-c11 repo:	# To re-build this tarball use the following in the sparsehash-c11 repo:
#  export NAME=sparsehash-c11-$(git rev-parse HEAD)	#  export NAME=sparsehash-c11-$(git rev-parse HEAD)
#  git archive HEAD --prefix=$NAME/ -o /tmp/$NAME.tar.gz	#  git archive HEAD --prefix=$NAME/ -o /tmp/$NAME.tar.gz
#  s3cmd put -P /tmp/$NAME.tar.gz s3://cloudera-thirdparty-libs/$NAME.tar.gz	#  s3cmd put -P /tmp/$NAME.tar.gz s3://cloudera-thirdparty-libs/$NAME.tar.gz

sparsepp:
https://github.com/greg7mdp/sparsepp/archive/1.22.tar.gz


-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 09:04:27 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14643 )

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................


Patch Set 1:

I uploaded both tarballs. Will retry your build.


-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Wed, 06 Nov 2019 09:43:21 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14643

to look at the new patch set (#3).

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................

[thirdparty] Bump sparsepp and sparsehash-c11 version

Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
---
M thirdparty/vars.sh
1 file changed, 2 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/14643/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has restored this change. ( http://gerrit.cloudera.org:8080/14643 )

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................


Restored
-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: restore
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14643 )

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................


Patch Set 3: Verified+1 Code-Review+2

Build passed, one shard of client-test failed due to NTP synchronization issues.


-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 08:06:33 +0000
Gerrit-HasComments: No

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>

[kudu-CR] [thirdparty] Bump sparsepp and sparsehash-c11 version

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has abandoned this change. ( http://gerrit.cloudera.org:8080/14643 )

Change subject: [thirdparty] Bump sparsepp and sparsehash-c11 version
......................................................................


Abandoned

error msg
-- 
To view, visit http://gerrit.cloudera.org:8080/14643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie04dd13ce8f9d338cf6d6b39f4df2c95886ba851
Gerrit-Change-Number: 14643
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>