[jira] [Commented] (BOOKKEEPER-836) disable compaction when disk becomes full, otherwise compaction will fill up disk quickly

["Flavio Junqueira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320793#comment-14320793 ] 

Flavio Junqueira commented on BOOKKEEPER-836:
---------------------------------------------

are we pushing this one for 4.3.2?

> disable compaction when disk becomes full, otherwise compaction will fill up disk quickly
> -----------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-836
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-836
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>    Affects Versions: 4.2.3
>            Reporter: Jia Zhai
>            Assignee: Jia Zhai
>             Fix For: 4.4.0, 4.3.1
>
>         Attachments: BOOKKEEPER-836.patch
>
>
> In doCompactEntryLogs, Entries are added to new logs, while all old logs were not released until the end of handling.  So during the process, a lot of space will be used. Need to disable compaction when disk becomes full, otherwise compaction will fill up disk quickly.
> I would like to change old "forced garbage collection" logic, and suspend major compaction when it reaches warn threshold, suspend minor compaction when it reaches critical threshold.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)