[GitHub] [airflow] kaxil commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module

[GitBox <gi...@apache.org>]

kaxil commented on issue #6718: [AIRFLOW-6162] Add back serialization as a module
URL: https://github.com/apache/airflow/pull/6718#issuecomment-561139443
 
 
   Yes unfortunately, subdag field is only set in 2 places. 1) In
   SubDagOperator and 2) In SerializedBaseOperator.
   
   
   
   On Tue, Dec 3, 2019, 12:04 Jarek Potiuk <no...@github.com> wrote:
   
   > *@potiuk* commented on this pull request.
   > ------------------------------
   >
   > In airflow/serialization/serialized_dag.py
   > <https://github.com/apache/airflow/pull/6718#discussion_r353139748>:
   >
   > > @@ -101,7 +102,7 @@ def deserialize_dag(cls, encoded_dag: dict) -> "SerializedDAG":
   >          setattr(dag, 'full_filepath', dag.fileloc)
   >          for task in dag.task_dict.values():
   >              task.dag = dag
   > -            serializable_task: SerializedBaseOperator = task
   > +            serializable_task: SerializedBaseOperator = cast(SerializedBaseOperator, task)
   >
   > I think the root cause is that .subdag field is only set in
   > SerializedBaseOperator and that's why the type is forced here.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/airflow/pull/6718?email_source=notifications&email_token=ACDHIJRK2BUGT2I7RAVJOELQWZDOTA5CNFSM4JUWMCP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNX3QWQ#discussion_r353139748>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ACDHIJUQCSU3UYLNHUZJQ63QWZDOVANCNFSM4JUWMCPQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services