You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/27 03:16:52 UTC

[GitHub] [hudi] YannByron opened a new pull request, #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

YannByron opened a new pull request, #6805:
URL: https://github.com/apache/hudi/pull/6805

   ### Change Logs
   
   copy the object if ser/de Row or Record
   
   ### Impact
   
   LOW


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1260646997

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 573c27aef34708f1b6019f0647a0ef7093c3a96a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1259604801

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 553617898625ce54efbe0f72bdad5c44c3906743 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #6805:
URL: https://github.com/apache/hudi/pull/6805#discussion_r980715777


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/cdc/HoodieCDCRDD.scala:
##########
@@ -318,7 +318,7 @@ class HoodieCDCRDD(
               val after = record.get(3).asInstanceOf[GenericRecord]
               recordToLoad.update(3, convertToUTF8String(HoodieCDCUtils.recordToJson(after)))
             case HoodieCDCSupplementalLoggingMode.WITH_BEFORE =>
-              val row = cdcRecordDeserializer.deserialize(record).get.asInstanceOf[InternalRow]
+              val row = cdcRecordDeserialize(record)

Review Comment:
   We actually don't need to copy it here right away: if someone just iterates over these records and simply writes them out into a file there would be no issue (and there's no need to make additional copies).
   
   However if we have a place where we do retain reference after iteration, like:
   
   ```
   val rows = iter.collect()
   ```
   
   Then we will need to make copies before we do that, like below:
   
   ```
   val copiedRows = iter.map(_.copy()).collect()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1259089860

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 591c0d34537bba9f3d1e20dab8ba01d5be60e738 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764) 
   * 553617898625ce54efbe0f72bdad5c44c3906743 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1263034687

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 573c27aef34708f1b6019f0647a0ef7093c3a96a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822) 
   * 075b993b608134f15eff7cab96b8e916369ae722 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1260371889

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 553617898625ce54efbe0f72bdad5c44c3906743 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779) 
   * 573c27aef34708f1b6019f0647a0ef7093c3a96a Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #6805:
URL: https://github.com/apache/hudi/pull/6805#discussion_r984015580


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/cdc/HoodieCDCRDD.scala:
##########
@@ -516,7 +515,7 @@ class HoodieCDCRDD(
         val iter = loadFileSlice(fileSlice)
         iter.foreach { row =>
           val key = getRecordKey(row)
-          beforeImageRecords.put(key, serialize(row))
+          beforeImageRecords.put(key, serialize(row, copy = true))

Review Comment:
   Let's add a comment explaining why we're copying here (to avoid confusion)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1259715553

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 553617898625ce54efbe0f72bdad5c44c3906743 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1259886623

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 553617898625ce54efbe0f72bdad5c44c3906743 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1258922284

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 591c0d34537bba9f3d1e20dab8ba01d5be60e738 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1263286639

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     }, {
       "hash" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 075b993b608134f15eff7cab96b8e916369ae722 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918) 
   * be8c12ec97231e1dd549cb3ece42a388e2976563 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1259246858

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 553617898625ce54efbe0f72bdad5c44c3906743 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1260369087

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 553617898625ce54efbe0f72bdad5c44c3906743 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779) 
   * 573c27aef34708f1b6019f0647a0ef7093c3a96a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] alexeykudinkin commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1261494818

   @YannByron please update all of your minor PR to actually reference the original Jira (for CDC) so all of them attached to that Jira ticket


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1264423605

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     }, {
       "hash" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925",
       "triggerID" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5baf6007d88f619ca2838c507c93d48e3c7f45",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11958",
       "triggerID" : "8b5baf6007d88f619ca2838c507c93d48e3c7f45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8b5baf6007d88f619ca2838c507c93d48e3c7f45 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11958) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1263291892

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     }, {
       "hash" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925",
       "triggerID" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 075b993b608134f15eff7cab96b8e916369ae722 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918) 
   * be8c12ec97231e1dd549cb3ece42a388e2976563 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1263501187

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     }, {
       "hash" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925",
       "triggerID" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * be8c12ec97231e1dd549cb3ece42a388e2976563 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] xushiyan merged pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #6805:
URL: https://github.com/apache/hudi/pull/6805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YannByron commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
YannByron commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1261819481

   > @YannByron please update all of your minor PR to actually reference the original Jira (for CDC) so all of them attached to that Jira ticket
   
   Create some child tickets that attachs to https://issues.apache.org/jira/browse/HUDI-3478


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1263032260

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 573c27aef34708f1b6019f0647a0ef7093c3a96a Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822) 
   * 075b993b608134f15eff7cab96b8e916369ae722 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1264386089

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     }, {
       "hash" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925",
       "triggerID" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5baf6007d88f619ca2838c507c93d48e3c7f45",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8b5baf6007d88f619ca2838c507c93d48e3c7f45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * be8c12ec97231e1dd549cb3ece42a388e2976563 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925) 
   * 8b5baf6007d88f619ca2838c507c93d48e3c7f45 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1258925187

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 591c0d34537bba9f3d1e20dab8ba01d5be60e738 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1259084606

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 591c0d34537bba9f3d1e20dab8ba01d5be60e738 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764) 
   * 553617898625ce54efbe0f72bdad5c44c3906743 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1263202127

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 075b993b608134f15eff7cab96b8e916369ae722 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YannByron commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
YannByron commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1260353253

   @alexeykudinkin 
   I found it can avoid to do serialize/deserialize in many cases,  only one case has to do this. so i do some optimization for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #6805: [HUDI-4949] optimize cdc read to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1264387150

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11764",
       "triggerID" : "591c0d34537bba9f3d1e20dab8ba01d5be60e738",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "triggerType" : "PUSH"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11792",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "553617898625ce54efbe0f72bdad5c44c3906743",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11779",
       "triggerID" : "1259565595",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11822",
       "triggerID" : "573c27aef34708f1b6019f0647a0ef7093c3a96a",
       "triggerType" : "PUSH"
     }, {
       "hash" : "075b993b608134f15eff7cab96b8e916369ae722",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11918",
       "triggerID" : "075b993b608134f15eff7cab96b8e916369ae722",
       "triggerType" : "PUSH"
     }, {
       "hash" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925",
       "triggerID" : "be8c12ec97231e1dd549cb3ece42a388e2976563",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8b5baf6007d88f619ca2838c507c93d48e3c7f45",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11958",
       "triggerID" : "8b5baf6007d88f619ca2838c507c93d48e3c7f45",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * be8c12ec97231e1dd549cb3ece42a388e2976563 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11925) 
   * 8b5baf6007d88f619ca2838c507c93d48e3c7f45 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11958) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YannByron commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
YannByron commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1259565595

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] YannByron commented on pull request #6805: [MINOR] copy to avoid the problem of reusing buffer underlying the Row

Posted by GitBox <gi...@apache.org>.
YannByron commented on PR #6805:
URL: https://github.com/apache/hudi/pull/6805#issuecomment-1259238333

   Verified locally and run successfully. Check the CI failure and not related to the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org