[GitHub] [hbase] Reidddddd commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL

[GitBox <gi...@apache.org>]

Reidddddd commented on a change in pull request #371: HBASE-22648 : Introducing Snapshot TTL
URL: https://github.com/apache/hbase/pull/371#discussion_r303280908
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/SnapshotDescription.java
 ##########
 @@ -139,15 +146,21 @@ public long getCreationTime() {
     return this.creationTime;
   }
 
+  // get snapshot ttl in sec
+  public long getTtl() {
+    return ttl;
+  }
+
   public int getVersion() {
     return this.version;
   }
 
   @Override
   public String toString() {
-    return "SnapshotDescription: name = " + ((name != null) ? name : null) + "/table = "
-        + ((table != null) ? table : null) + " /owner = " + ((owner != null) ? owner : null)
-        + (creationTime != -1 ? ("/creationtime = " + creationTime) : "")
-        + (version != -1 ? ("/version = " + version) : "");
+    return "SnapshotDescription: name = " + name + "/table = "
 
 Review comment:
   Can we use StringBuilder to improve the readability?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services