You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Anoop Sam John (JIRA)" <ji...@apache.org> on 2016/02/29 12:32:18 UTC
[jira] [Comment Edited] (HBASE-14099)
StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start
and stop Row
[ https://issues.apache.org/jira/browse/HBASE-14099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171769#comment-15171769 ]
Anoop Sam John edited comment on HBASE-14099 at 2/29/16 11:31 AM:
------------------------------------------------------------------
[~appy] As this was fixed long time back, we can raise ur observation as a new bug and close this one? Can you raise it pls?
was (Author: anoop.hbase):
[~appy] As this was fixed and long time back, we can raise ur observation as a new bug and close this one?
> StoreFile.passesKeyRangeFilter need not create Cells from the Scan's start and stop Row
> ---------------------------------------------------------------------------------------
>
> Key: HBASE-14099
> URL: https://issues.apache.org/jira/browse/HBASE-14099
> Project: HBase
> Issue Type: Improvement
> Components: Performance, Scanners
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-14099.patch, HBASE-14099_1.patch, HBASE-14099_2.patch, HBASE-14099_3.patch, HBASE-14099_4.patch, hfiles_and_testclass.zip, storefile.png
>
>
> During profiling saw that the code here in passesKeyRangeFilter in Storefile
> {code}
> KeyValue smallestScanKeyValue = scan.isReversed() ? KeyValueUtil
> .createFirstOnRow(scan.getStopRow()) : KeyValueUtil.createFirstOnRow(scan
> .getStartRow());
> KeyValue largestScanKeyValue = scan.isReversed() ? KeyValueUtil
> .createLastOnRow(scan.getStartRow()) : KeyValueUtil.createLastOnRow(scan
> .getStopRow());
> {code}
> This row need not be copied now considering that we have CellComparator.compareRows(Cell, byte[]).
> We have already refactored the firstKeyKv and lastKeyKV as part of other JIRAs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)