[jira] [Created] (MESOS-9056) apply-reviews.sh messaging and dependency management .

["Till Toenshoff (JIRA)" <ji...@apache.org>]

Till Toenshoff created MESOS-9056:
-------------------------------------

             Summary: apply-reviews.sh messaging and dependency management .
                 Key: MESOS-9056
                 URL: https://issues.apache.org/jira/browse/MESOS-9056
             Project: Mesos
          Issue Type: Bug
    Affects Versions: 1.7.0
            Reporter: Till Toenshoff


After running into all sorts of issues connected to the {{-c}} option, at some point I tried the {{-k}} option and got the following output;

{noformat}
$ support/apply-reviews.py -k -r 67842
Congratulations! You have Python 3 installed correctly.
Please start using the scripts in `support/python3`.
Please also set the environment variable `MESOS_SUPPORT_PYTHON` to `3`
so that the Git hooks use the Python 3 scripts.
2018-07-07 18:35:07 URL:https://reviews.apache.org/r/67842/diff/raw/ [5879/5879] -> "67842.patch" [1]
Congratulations! You have Python 3 installed correctly.
Please start using the scripts in `support/python3`.
Please also set the environment variable `MESOS_SUPPORT_PYTHON` to `3`
so that the Git hooks use the Python 3 scripts.
No C++ files to lint
No JavaScript files to lint
Checking 1 Python file
usage: tox [--version] [-h] [--help-ini] [-v] [--showconfig] [-l] [-a]
           [-c CONFIGFILE] [-e envlist] [--notest] [--sdistonly]
           [--installpkg PATH] [--develop] [-i URL] [--pre] [-r]
           [--result-json PATH] [--hashseed SEED] [--force-dep REQ]
           [--sitepackages] [--alwayscopy] [--skip-missing-interpreters]
           [--workdir PATH]
           [args [args ...]]
tox: error: unrecognized arguments: -qq
Total errors found: 0
Congratulations! You have Python 3 installed correctly.
Please start using the scripts in `support/python3`.
Please also set the environment variable `MESOS_SUPPORT_PYTHON` to `3`
so that the Git hooks use the Python 3 scripts.
[...]
 1 file changed, 35 insertions(+), 29 deletions(-)
{noformat}

It appears that the messaging here is worth reconsidering;
- instead of "congratulating" three times - how about we warn/error if python3 is not installed?
- apparently {{tox}} is outdated in my virtual-env - maybe we could run buildvirtualenv automatically in such cases?
- "so that the Git hooks use the Python 3 scripts." should not have a forced linefeed




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)