[GitHub] [lucene-solr] msokolov opened a new pull request #722: LUCENE-8863: handle some edge cases in Kuromoji DictionaryBuilder, en…

[GitBox <gi...@apache.org>]

msokolov opened a new pull request #722: LUCENE-8863: handle some edge cases in Kuromoji DictionaryBuilder, en…
URL: https://github.com/apache/lucene-solr/pull/722
 
 
   …abling 13-bit ids
   
   I'm sharing this without tests, for comment, while I try to get the tests running. I'm having trouble with
   
   ```
       cd ~/workspace/lucene-solr/lucene/analysis/kuromoji; ant test-tools
   ```
   
   first I had to make this patch, 
   
   ```
      <target name="test-tools" depends="compile-tools-tests">
   -    <test-macro dataDir="src/tools/test" junit.classpath="tools.test.classpath"/>
   +    <test-macro workDir="src/tools/test" junit.classpath="tools.test.classpath"/>
      </target>
   ```
   
   now I'm getting this error:
   
   ```
   /home/ANT.AMAZON.COM/sokolovm/workspace/lucene-solr/lucene/common-build.xml:964: Problem: failed to create task or type antlib:com.carrotsearch.junit4:pickseed
   Cause: The name is undefined.
   ```
   
   which all makes me wonder whether test-tools has become obsolete?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org