You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Kenneth Knowles (JIRA)" <ji...@apache.org> on 2016/11/28 18:24:58 UTC

[jira] [Commented] (BEAM-230) Remove WindowedValue#valueInEmptyWindows

    [ https://issues.apache.org/jira/browse/BEAM-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702714#comment-15702714 ] 

Kenneth Knowles commented on BEAM-230:
--------------------------------------

This wasn't actually removed completely.

> Remove WindowedValue#valueInEmptyWindows
> ----------------------------------------
>
>                 Key: BEAM-230
>                 URL: https://issues.apache.org/jira/browse/BEAM-230
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Kenneth Knowles
>              Labels: backward-incompatible
>             Fix For: Not applicable
>
>
> A WindowedValue in no windows does not exist, and can be dropped by a runner at any time.
> We should also assert that any collection of windows is nonempty when creating a new WindowedValue. If a user wants to drop an element, they should explicitly filter it out rather than expecting it to be dropped by the runner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)