You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/23 20:21:38 UTC

[GitHub] [tvm] tkonolige commented on a change in pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers

tkonolige commented on a change in pull request #7153:
URL: https://github.com/apache/tvm/pull/7153#discussion_r548204295



##########
File path: cmake/modules/Libbacktrace.cmake
##########
@@ -0,0 +1,18 @@
+include(ExternalProject)
+
+ExternalProject_Add(project_libbacktrace

Review comment:
       Thanks for the heads up. I've fixed it so that libbacktrace.a depends on its sources correctly. Note that there is a bug with cmake and ninja where dependencies aren't tracked correctly, so you'll have to build twice with ninja when updating libbacktrace. But with make everything works fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org