[GitHub] [superset] rusackas commented on pull request #24368: feat: make data tables support html

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #24368:
URL: https://github.com/apache/superset/pull/24368#issuecomment-1591858100

   > The feature is very best，I need it too.
   > 
   > But, I hope to that, **Add a config item** by Web UI ，rather than **CONCAT In sql** ，
   > 
   > What are your ideas ？ @mistercrunch
   > 
   > ![image](https://user-images.githubusercontent.com/24838476/245684959-74a7f450-fa73-40fb-8d59-f15ea963fc95.png)
   
   I think the concat is nice in that it allows you to re-use the columnar data anywhere needed in the link. For example, a Github issue ID is used as the linked text AND a particular spot in the URL. If we were to add a link to the UI, we would need some form of syntax (e.g. handlebars/jinja) that would allow you to construct the link in the correct way... and that can have security-related concerns.
   
   I love the idea of it being in the UI, but I'm having a hard time thinking of a way to do it that's both simple and secure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org