You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "quic-sanirudh (via GitHub)" <gi...@apache.org> on 2023/10/13 13:48:41 UTC
[PR] [Relay] Expose qnn ops directly from relay.qnn module [tvm]
quic-sanirudh opened a new pull request, #15928:
URL: https://github.com/apache/tvm/pull/15928
When we access `nn` ops in relay, we can directly access them as `relay.nn.<op>` where `<op>` can be any nn op like `conv2d`, `avg_pool2d`, etc.
When we access `qnn` ops, we need to access them as `relay.qnn.op.<op>` as they're not exposed to the `relay.qnn` module. This change tries to add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relay] Expose qnn ops directly from relay.qnn module [tvm]
Posted by "ibsidorenko (via GitHub)" <gi...@apache.org>.
ibsidorenko commented on PR #15928:
URL: https://github.com/apache/tvm/pull/15928#issuecomment-1763868372
LGTM. Do you plan to change access names in unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relay] Expose qnn ops directly from relay.qnn module [tvm]
Posted by "quic-sanirudh (via GitHub)" <gi...@apache.org>.
quic-sanirudh commented on PR #15928:
URL: https://github.com/apache/tvm/pull/15928#issuecomment-1763964991
> LGTM. Do you plan to change access names in unit tests?
Thanks for the review, and yes, I'll update the tests and push it today. Initially I thought it might introduce a lot of changes that hurts git history un-necessarily, but now I think there could be some advantage to doing it (especially since tests are seen as an initial source of example usage of an API).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relay] Expose qnn ops directly from relay.qnn module [tvm]
Posted by "quic-sanirudh (via GitHub)" <gi...@apache.org>.
quic-sanirudh merged PR #15928:
URL: https://github.com/apache/tvm/pull/15928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Relay] Expose qnn ops directly from relay.qnn module [tvm]
Posted by "quic-sanirudh (via GitHub)" <gi...@apache.org>.
quic-sanirudh commented on PR #15928:
URL: https://github.com/apache/tvm/pull/15928#issuecomment-1763425961
cc @ibsidorenko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org