[GitHub] [skywalking] wu-sheng commented on a change in pull request #4116: keep the properties in SnifferConfigInitializer

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4116: keep the properties in SnifferConfigInitializer
URL: https://github.com/apache/skywalking/pull/4116#discussion_r361137430
 
 

 ##########
 File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
 ##########
 @@ -40,7 +40,7 @@
     private static String DEFAULT_CONFIG_FILE_NAME = "/config/agent.config";
     private static String ENV_KEY_PREFIX = "skywalking.";
     private static boolean IS_INIT_COMPLETED = false;
-
+    private static Properties properties;
 
 Review comment:
   Why change this? Who will use this properties? If not, this uses memory and gc load.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services