You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2013/11/14 00:02:30 UTC
Review Request 15500:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15500/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
Hard tabs found with support/mesos-style.py
We have a zero count again after this patch. Might be worthwhile to crank up the pedanticness of cpplint soon.
Diffs
-----
src/slave/monitor.cpp b49fd05
Diff: https://reviews.apache.org/r/15500/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 15500: Hard tabs in monitor.cpp
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15500/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 11:03 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Missed review request summary during Proxy Error.
Summary (updated)
-----------------
Hard tabs in monitor.cpp
Repository: mesos-git
Description
-------
Hard tabs found with support/mesos-style.py
We have a zero count again after this patch. Might be worthwhile to crank up the pedanticness of cpplint soon.
Diffs
-----
src/slave/monitor.cpp b49fd05
Diff: https://reviews.apache.org/r/15500/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 15500: Hard tabs in monitor.cpp
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15500/#review28876
-----------------------------------------------------------
committed. please mark it as submitted.
- Vinod Kone
On Nov. 13, 2013, 11:04 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15500/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 11:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hard tabs found with support/mesos-style.py
>
> We have a zero count again after this patch. Might be worthwhile to crank up the pedanticness of cpplint soon.
>
>
> Diffs
> -----
>
> src/slave/monitor.cpp b49fd05
>
> Diff: https://reviews.apache.org/r/15500/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 15500: Hard tabs in monitor.cpp
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15500/#review28852
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Nov. 13, 2013, 11:04 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15500/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 11:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hard tabs found with support/mesos-style.py
>
> We have a zero count again after this patch. Might be worthwhile to crank up the pedanticness of cpplint soon.
>
>
> Diffs
> -----
>
> src/slave/monitor.cpp b49fd05
>
> Diff: https://reviews.apache.org/r/15500/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 15500: Hard tabs in monitor.cpp
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15500/#review28849
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 13, 2013, 11:04 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15500/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2013, 11:04 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hard tabs found with support/mesos-style.py
>
> We have a zero count again after this patch. Might be worthwhile to crank up the pedanticness of cpplint soon.
>
>
> Diffs
> -----
>
> src/slave/monitor.cpp b49fd05
>
> Diff: https://reviews.apache.org/r/15500/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 15500: Hard tabs in monitor.cpp
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15500/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 11:04 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Trying again.
Summary (updated)
-----------------
Hard tabs in monitor.cpp
Repository: mesos-git
Description
-------
Hard tabs found with support/mesos-style.py
We have a zero count again after this patch. Might be worthwhile to crank up the pedanticness of cpplint soon.
Diffs
-----
src/slave/monitor.cpp b49fd05
Diff: https://reviews.apache.org/r/15500/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 15500:
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15500/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 11:04 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
Hard tabs found with support/mesos-style.py
We have a zero count again after this patch. Might be worthwhile to crank up the pedanticness of cpplint soon.
Diffs
-----
src/slave/monitor.cpp b49fd05
Diff: https://reviews.apache.org/r/15500/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
Re: Review Request 15500:
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15500/
-----------------------------------------------------------
(Updated Nov. 13, 2013, 11:03 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
Hard tabs found with support/mesos-style.py
We have a zero count again after this patch. Might be worthwhile to crank up the pedanticness of cpplint soon.
Diffs
-----
src/slave/monitor.cpp b49fd05
Diff: https://reviews.apache.org/r/15500/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen