You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/23 14:56:16 UTC
[GitHub] [superset] kicaak edited a comment on pull request #15433: chore: Uses mixed case for native filters headers
kicaak edited a comment on pull request #15433:
URL: https://github.com/apache/superset/pull/15433#issuecomment-885685647
@junlincc Sure! I have an initial idea, it's quite hard to do it without using the visual representation of the parent - children relationship, but I hope I will be able to help 🤞 I have a few questions/comments about how it works now too.
**Current behaviour**
I have one parent and one child filter. When I open the popover and select one value in the parent filter not only I am not able to go back to the initial popover state (I need to close it and reopen it), but also on the left the field where before was "parent" filter got switched to child filter which is empty. So I kind of had no idea which filter I was editing. This was super confusing to me, is it the expected behaviour?
**Initial exploration**
I tried out a few things and for now I am thinking about adding labels with the name of the parent filter (designs and copy are quite rough now, but wanted to share the concept). This would at least a little bit indicate what this filter is related to, also added a little indentation of the children's children filters etc, not sure about it yet.
I added collapsing/expanding of the children. It can be used in the popover, but I thought it could be more intuitive to add it in the left navigation with all of the filters. You can play the prototype [here](https://www.figma.com/proto/jxQD12WvnW63PTK7UFeNzr/Preset_KZ?page-id=2%3A4&node-id=5%3A1214&viewport=-2508%2C-264%2C0.23226340115070343&scaling=min-zoom&starting-point-node-id=5%3A1214). [Here](https://www.figma.com/file/jxQD12WvnW63PTK7UFeNzr/Preset_KZ?node-id=2%3A4) is figma file.
[Here](https://www.figma.com/proto/jxQD12WvnW63PTK7UFeNzr/Preset_KZ?page-id=2%3A4&node-id=5%3A1571&viewport=-2508%2C-264%2C0.23226340115070343&scaling=min-zoom&starting-point-node-id=5%3A1571&show-proto-sidebar=1) is the prototype of the popover. I added a tooltip as I think it makes it more clear what this pill refers to.
Let me know what you think 😌
**Improvement**
I thought that the filers and filter groups can take a long time to create by the user, so maybe it would be nice to let them set some filters/groups to active/not active when applying them?
_Use case:_ I have four group of filters which are quite extensive. All of them work at the same time well, but for some reason I would like to see results only from two groups and right now to do it, I think I would have to remove other two.
_Solution:_ I set two groups to _not active_ and run the filters with "Apply" button. When it comes to the design - I was thinking about the visual indicator of the active/inactive group or filter. Icon could be placed next to the main parent (single filter, master parent) and that would be enough. This could be for example the icon that now triggers the popover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org