You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/03 16:48:31 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request #6263: parse top expr for SQLServer query

strongduanmu opened a new pull request #6263:
URL: https://github.com/apache/shardingsphere/pull/6263


   Fixes #4867 .
   
   Changes proposed in this pull request:
   - modify the `TOP` rule in DMLStatement.g4 of SQLServer
   - add function `visitTop()` to parse the `TOP` rule
   - add parse test cases to check `TOP` rule
   - modify the relative test cases in `select-pagination.xml` and `select-pagination-group-by-order-by.xml`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #6263: parse top(expression) for SQLServer query

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6263:
URL: https://github.com/apache/shardingsphere/pull/6263#issuecomment-653761832


   Hi @strongduanmu top-notch work! I become to believe in your work more and more!
   
   Thanks to your PR, #6192 will be closed later. 
   
   BTW, this PR just makes `TOP()` parsed well, but this feature also needs more work, like `Rewriting TOP() SQL`.
   
   That is, the next sub-task it to uncomment the SQL cases labeled as `FIXME` and make them run well in `./incubator-shardingsphere/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-rewrite/src/test/resources/sharding/select.xml`
   This sub-task will give the contributor a chance to learn more about SQL rewrite module. You know, it the connsequent process after parsing. :-)
   
   Are you interested in this consequent task? I mean, It is not forced, just a question for your interest.
   So please take it easy. Waiting for your response.  :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #6263: parse top(expression) for SQLServer query

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6263:
URL: https://github.com/apache/shardingsphere/pull/6263#issuecomment-653773878


   > @tristaZero Thanks for your review. I am very interested in the consequent task and I will complete it as soon as possible. 😀
   
   Waiting for that! 😉 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #6263: parse top(expression) for SQLServer query

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #6263:
URL: https://github.com/apache/shardingsphere/pull/6263#issuecomment-653763969


   @tristaZero Thanks for your review. I am very interested in the consequent task and I will complete it as soon as possible. 😀


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #6263: parse top(expression) for SQLServer query

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6263:
URL: https://github.com/apache/shardingsphere/pull/6263


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org