You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Ash Berlin-Taylor (JIRA)" <ji...@apache.org> on 2018/08/04 16:53:00 UTC
[jira] [Issue Comment Deleted] (AIRFLOW-1102) 'airflow webserver'
doesn't work with gunicorn 19.4+
[ https://issues.apache.org/jira/browse/AIRFLOW-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ash Berlin-Taylor updated AIRFLOW-1102:
---------------------------------------
Comment: was deleted
(was: ashb closed pull request #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+
URL: https://github.com/apache/incubator-airflow/pull/2237
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/airflow/bin/cli.py b/airflow/bin/cli.py
index e4755c7a82..9f95f3e25b 100755
--- a/airflow/bin/cli.py
+++ b/airflow/bin/cli.py
@@ -776,7 +776,7 @@ def webserver(args):
'-t', str(worker_timeout),
'-b', args.hostname + ':' + str(args.port),
'-n', 'airflow-webserver',
- '-c', 'airflow.www.gunicorn_config'
+ '-c', 'python:airflow.www.gunicorn_config'
]
if args.access_logfile:
diff --git a/setup.py b/setup.py
index 669120800a..d6a8bea989 100644
--- a/setup.py
+++ b/setup.py
@@ -218,7 +218,7 @@ def do_setup():
'funcsigs==1.0.0',
'future>=0.16.0, <0.17',
'gitpython>=2.0.2',
- 'gunicorn>=19.3.0, <19.4.0', # 19.4.? seemed to have issues
+ 'gunicorn>=19.4.0',
'jinja2>=2.7.3, <2.9.0',
'lxml>=3.6.0, <4.0',
'markdown>=2.5.2, <3.0',
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
)
> 'airflow webserver' doesn't work with gunicorn 19.4+
> ----------------------------------------------------
>
> Key: AIRFLOW-1102
> URL: https://issues.apache.org/jira/browse/AIRFLOW-1102
> Project: Apache Airflow
> Issue Type: Bug
> Components: dependencies
> Reporter: Yuu Yamashita
> Priority: Major
> Fix For: 1.9.0
>
>
> {{airflow webserver}} will show an error of "Error: 'airflow.www.gunicorn_config' doesn't exist" if it invoked with gunicorn 19.4+, just like the following example.
> {noformat}
> % airflow webserver
> [2017-04-11 05:34:28,945] {__init__.py:57} INFO - Using executor LocalExecutor
> ____________ _____________
> ____ |__( )_________ __/__ /________ __
> ____ /| |_ /__ ___/_ /_ __ /_ __ \_ | /| / /
> ___ ___ | / _ / _ __/ _ / / /_/ /_ |/ |/ /
> _/_/ |_/_/ /_/ /_/ /_/ \____/____/|__/
> [2017-04-11 05:34:29,968] [32339] {models.py:167} INFO - Filling up the DagBag from ./dags
> [2017-04-11 05:34:30,427] [32339] {connectionpool.py:735} INFO - Starting new HTTPS connection (1): sts.amazonaws.com
> Running the Gunicorn Server with:
> Workers: 4 sync
> Host: 0.0.0.0:8081
> Timeout: 120
> Logfiles: - -
> =================================================================
> Error: 'airflow.www.gunicorn_config' doesn't exist
> {noformat}
> At present, it seems that airflow is configured to require gunicorn prior to 19.4. It should be fixed intrinsically for future upgrade of gunicorn anyways.
> https://github.com/benoitc/gunicorn/blob/19.4/gunicorn/app/base.py#L111-L119
> Starting from {{gunicorn}} 9.4, it seems it started requiring prefix "python:" for module name passed to {{-c}}. Because {{airflow webserver}} [is specifying airflow.www.gunicorn_config|https://github.com/apache/incubator-airflow/blob/6b1c327ee886488eedbe8a8721708b89f37d5560/airflow/bin/cli.py#L779] as {{-c}} for {{gunicorn}}, it won't work with gunicorn 9.4+
> * gunicorn 9.3: https://github.com/benoitc/gunicorn/blob/19.3/gunicorn/app/base.py#L111-L114
> * gunicorn 9.4: https://github.com/benoitc/gunicorn/blob/19.4/gunicorn/app/base.py#L111-L119
> I've opened [a PR to gunicorn|https://github.com/benoitc/gunicorn/pull/1499] to restore original behavior prior to 19.3. However, it'd be also better to be fixed in {{airflow webserver}} itself.
> h5. See also
> * https://github.com/benoitc/gunicorn/pull/1068
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)