[GitHub] [iceberg] TGooch44 commented on a change in pull request #2761: Add an implemention of STARTS_WITH for Python API.

[GitBox <gi...@apache.org>]

TGooch44 commented on a change in pull request #2761:
URL: https://github.com/apache/iceberg/pull/2761#discussion_r679070069



##########
File path: python/iceberg/api/expressions/expression_parser.py
##########
@@ -44,7 +44,7 @@
 ident = Word(alphas, alphanums + "_$").setName("identifier")
 columnName = delimitedList(ident, ".", combine=True).setName("column name")
 
-binop = oneOf("= == != < > >= <= eq ne lt le gt ge <>", caseless=False)
+binop = oneOf("= == != < > >= <= eq ne lt le gt ge <> startsWith", caseless=False)

Review comment:
       > I think there might be some arrow stuff to add, but that might be outdated. A few comments.
   
   Was there something you are thinking of specifically? I think just the dataset filter translation  is all that's needed for what's currently in the read path.  I could be missing something though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org