[GitHub] [incubator-superset] ktmud commented on a change in pull request #11667: feat: replace edit modal with Explore navigation in chart cards/list

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #11667:
URL: https://github.com/apache/incubator-superset/pull/11667#discussion_r536520277



##########
File path: superset-frontend/src/views/CRUD/chart/ChartCard.tsx
##########
@@ -112,10 +110,12 @@ export default function ChartCard({
       )}
       {canEdit && (
         <Menu.Item
-          data-test="chart-list-edit-option"
+          data-test="chart-list-explore-option"
           role="button"
           tabIndex={0}
-          onClick={() => openChartEditModal(chart)}
+          onClick={() => {
+            window.location.href = chart.url;
+          }}

Review comment:
       Can we make this an actual `<a href>` instead of URL redirect via `location.href`? A lot of people uses `Cmd + Click` to open links in background tabs, using redirects in `onClick` wouldn't work for this use case.
   
   Plus it should probably open in a new window.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org