[jira] [Comment Edited] (AURORA-1169) Version ID in gradle expands to invalid value on Windows

["Matias Lahti (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363501#comment-14363501 ] 

Matias Lahti edited comment on AURORA-1169 at 3/16/15 5:13 PM:
---------------------------------------------------------------

Some testing showed that cloning within vagrant locally from /vagrant (eg the shared repository) is enough to make things work on Windows. e2e testing also succeeds after a small patch*. I created a review request for this, hopefully it's up to your standards - https://reviews.apache.org/r/32114

Note that using git archive does NOT work, due to .gitattributes ignoring gradlew/gradle when exporting, and thus my solution clones the git and then rsyncs from the clone along the lines of what used to happen before.

*) version check needs to check from /home/vagrant/aurora/.auroraversion rather than /vagrant/.auroraversion, as due to the same problem as discussed above


was (Author: moitias):
Some testing showed that cloning within vagrant locally from /vagrant (eg the shared repository) is enough to make things work on Windows. e2e testing also succeeds after a small patch*. I created a review request for this, hopefully it's up to your standards - https://reviews.apache.org/r/32114

Note that using git archive does NOT work, due to .gitattributes ignoring gradlew/gradle when exporting, and thus my solution clones the git and then rsyncs from the clone along the lines of what used to happen before.

*) version check needs to check from /home/vagrant/aurora/.auroraversion rather than /vagrant/.auroraversion, as due to the same problem as above, /vagrant/.auroraversion is not a symlink to the actual version file but just contains the filename of the actual version file.

> Version ID in gradle expands to invalid value on Windows
> --------------------------------------------------------
>
>                 Key: AURORA-1169
>                 URL: https://issues.apache.org/jira/browse/AURORA-1169
>             Project: Aurora
>          Issue Type: Bug
>          Components: Build
>            Reporter: Bill Farner
>            Assignee: Bill Farner
>            Priority: Minor
>
> Reported in IRC.  Apparently it's possible for this line in the build.gradle:
> {noformat}
> version = file("${rootDir}/.auroraversion").text.trim().toUpperCase()
> {noformat}
> To expand to:
> {noformat}
> SRC/MAIN/RESOURCES/APACHE/AURORA/CLIENT/CLI/.AURORAVERSION.jar
> {noformat}
> The result is a failure to install jars to the correct locations, and a non-functioning scheduler.
> Transcript:
> {noformat}
> <wfarner> how about in /home/vagrant/aurora/dist/libs
> <JakeXKS> well there is /home/vagrant/aurora/dist/libs/aurora-SRC/MAIN/RESOURCES/APACHE/AURORA/CLIENT/CLI/.AURORAVERSION.jar
> JakeXKS> Vagrant 1.7.2 Virtualbox 4.3.24
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)