You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/07/16 11:23:38 UTC

Review Request 67924: Mentioned linters `mesos-style.py` and `mesos-tidy.sh` in style guide.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67924/
-----------------------------------------------------------

Review request for mesos and James Peach.


Repository: mesos


Description
-------

Mentioned linters `mesos-style.py` and `mesos-tidy.sh` in style guide.


Diffs
-----

  docs/c++-style-guide.md 80a1af318984d47bdfa641aa12e28963d3183fea 


Diff: https://reviews.apache.org/r/67924/diff/1/


Testing
-------

Verified good site rendering.


Thanks,

Benjamin Bannier


Re: Review Request 67924: Mentioned linters `mesos-style.py` and `mesos-tidy.sh` in style guide.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67924/#review206098
-----------------------------------------------------------



PASS: Mesos patch 67924 was successfully built and tested.

Reviews applied: `['67924']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1929/mesos-review-67924

- Mesos Reviewbot Windows


On July 16, 2018, 11:23 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67924/
> -----------------------------------------------------------
> 
> (Updated July 16, 2018, 11:23 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentioned linters `mesos-style.py` and `mesos-tidy.sh` in style guide.
> 
> 
> Diffs
> -----
> 
>   docs/c++-style-guide.md 80a1af318984d47bdfa641aa12e28963d3183fea 
> 
> 
> Diff: https://reviews.apache.org/r/67924/diff/1/
> 
> 
> Testing
> -------
> 
> Verified good site rendering.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 67924: Mentioned linters `mesos-style.py` and `mesos-tidy.sh` in style guide.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67924/#review206380
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On July 16, 2018, 11:23 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67924/
> -----------------------------------------------------------
> 
> (Updated July 16, 2018, 11:23 a.m.)
> 
> 
> Review request for mesos and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mentioned linters `mesos-style.py` and `mesos-tidy.sh` in style guide.
> 
> 
> Diffs
> -----
> 
>   docs/c++-style-guide.md 80a1af318984d47bdfa641aa12e28963d3183fea 
> 
> 
> Diff: https://reviews.apache.org/r/67924/diff/1/
> 
> 
> Testing
> -------
> 
> Verified good site rendering.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>