[jira] [Commented] (FLINK-6444) Add a check that '@VisibleForTesting' methods are only used in tests

["mingleizhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160925#comment-16160925 ] 

mingleizhang commented on FLINK-6444:
-------------------------------------

Hello, [~StephanEwen] . I would like work on this. But I need check it with you with some points in order to have a better understanding what you were trying to say. What you mean is when I type mvn clean install -DskipTests, then those method which has @VisibleForTesting is still called from non-tests. So, we should do something which can prevent it from this. I am correct ?

> Add a check that '@VisibleForTesting' methods are only used in tests
> --------------------------------------------------------------------
>
>                 Key: FLINK-6444
>                 URL: https://issues.apache.org/jira/browse/FLINK-6444
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Stephan Ewen
>
> Some methods are annotated with {{@VisibleForTesting}}. These methods should only be called from tests.
> This is currently not enforced / checked during the build. We should add such a check.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)