You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/06/20 10:29:31 UTC
[GitHub] [james-project] vttranlina opened a new pull request, #1058: Setting name for each container when run testcontainer
vttranlina opened a new pull request, #1058:
URL: https://github.com/apache/james-project/pull/1058
- By default, the testcontainer randomize the name for each container when start new.
The assign name of container will be easier to track on local when development
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1058: Setting name for each container when run testcontainer
Posted by GitBox <gi...@apache.org>.
Arsnael commented on PR #1058:
URL: https://github.com/apache/james-project/pull/1058#issuecomment-1160298167
```
10:35:01,963 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project metrics-es-reporter-v7: Compilation failure
10:35:01,963 [ERROR] /home/jenkins/workspace/james_ApacheJames_PR-1058/server/container/metrics/metrics-es-reporter-v7/src/test/java/org/apache/james/metric/es/v7/ES2ReporterTest.java:[30,46] cannot find symbol
10:35:01,963 [ERROR] symbol: variable ELASTICSEARCH_2
10:35:01,963 [ERROR] location: interface org.apache.james.util.docker.Images
10:35:01,963 [ERROR] -> [Help 1]
```
Elastocsearch image v2 is used in es metrics reporter module as well :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1058: Setting name for each container when run testcontainer
Posted by GitBox <gi...@apache.org>.
Arsnael commented on code in PR #1058:
URL: https://github.com/apache/james-project/pull/1058#discussion_r901531395
##########
server/testing/src/main/java/org/apache/james/util/docker/Images.java:
##########
@@ -22,10 +22,8 @@
public interface Images {
String FAKE_SMTP = "weave/rest-smtp-sink:latest";
String RABBITMQ = "rabbitmq:3.9.18-management";
- String ELASTICSEARCH_2 = "elasticsearch:2.4.6";
String ELASTICSEARCH_6 = "docker.elastic.co/elasticsearch/elasticsearch:6.3.2";
String ELASTICSEARCH_7 = "docker.elastic.co/elasticsearch/elasticsearch:7.10.2";
- String NGINX = "nginx:1.22";
Review Comment:
Why deleting this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1058: Setting name for each container when run testcontainer
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1058:
URL: https://github.com/apache/james-project/pull/1058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1058: Setting name for each container when run testcontainer
Posted by GitBox <gi...@apache.org>.
vttranlina commented on code in PR #1058:
URL: https://github.com/apache/james-project/pull/1058#discussion_r901537789
##########
server/testing/src/main/java/org/apache/james/util/docker/Images.java:
##########
@@ -22,10 +22,8 @@
public interface Images {
String FAKE_SMTP = "weave/rest-smtp-sink:latest";
String RABBITMQ = "rabbitmq:3.9.18-management";
- String ELASTICSEARCH_2 = "elasticsearch:2.4.6";
String ELASTICSEARCH_6 = "docker.elastic.co/elasticsearch/elasticsearch:6.3.2";
String ELASTICSEARCH_7 = "docker.elastic.co/elasticsearch/elasticsearch:7.10.2";
- String NGINX = "nginx:1.22";
Review Comment:
It uses only for quick test containers library, and nowhere re-use it. Remove it will be less noise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org