[GitHub] [ozone] guihecheng commented on pull request #2070: HDDS-4976. Add localcontainerinfo subcommand to debug

[GitBox <gi...@apache.org>]

guihecheng commented on pull request #2070:
URL: https://github.com/apache/ozone/pull/2070#issuecomment-804762696


   > Thanks @guihecheng for working on this. I would like to suggest some changes:
   > 
   > 1. To prevent proliferation of "random" subcommands under `ozone debug`, please group container-related debug commands under `ozone debug container`.  See [ContainerCommands](https://github.com/apache/ozone/blob/85af50b84f2ecba81ff6b67095c4cd082da7b59f/hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ContainerCommands.java) for an example of how to do it.  The description of `ozone debug container` could explain that its subcommands operate on local container replicas and should be executed on datanodes only.  Existing `export-container` command would become `ozone debug container export`.
   
   Sounds a good idea, I remenber Sammi Chen mentioned this idea to too, we'll do that together.
   
   > 2. To be consistent with other similar commands, I think we should separate the new operation into two subcommands: `ozone debug container list` and `... info`.  Container ID should be a required `@Parameter` for `info`.
   
   OK, it seems cleaner to have separated commands.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org