You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2010/07/13 17:13:53 UTC
[jira] Issue Comment Edited: (LUCENE-2213) Small improvements to
ArrayUtil.getNextSize
[ https://issues.apache.org/jira/browse/LUCENE-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887795#action_12887795 ]
Chris Male edited comment on LUCENE-2213 at 7/13/10 11:12 AM:
--------------------------------------------------------------
Then make it abstract. My suggestion has nothing to do with user level, but stems from a pattern I see very regularly in code. But since you seem so vehemently against it, I'll happily support removing it.
was (Author: cmale):
Then make it abstract. My suggestion has nothing to do with user level, but stems from a pattern I see very regularly in code. But since you seem to vehemently against it, I'll happily support removing it.
> Small improvements to ArrayUtil.getNextSize
> -------------------------------------------
>
> Key: LUCENE-2213
> URL: https://issues.apache.org/jira/browse/LUCENE-2213
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2213-mergetest.patch, LUCENE-2213.patch, LUCENE-2213.patch, LUCENE-2213.patch, LUCENE-2213.patch
>
>
> Spinoff from java-dev thread "Dynamic array reallocation algorithms" started on Jan 12, 2010.
> Here's what I did:
> * Keep the +3 for small sizes
> * Added 2nd arg = number of bytes per element.
> * Round up to 4 or 8 byte boundary (if it's 32 or 64 bit JRE respectively)
> * Still grow by 1/8th
> * If 0 is passed in, return 0 back
> I also had to remove some asserts in tests that were checking the actual values returned by this method -- I don't think we should test that (it's an impl. detail).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org