You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/07/28 09:14:19 UTC
[GitHub] [pinot] saurabhd336 opened a new pull request, #9121: Allow bloom filters for non dicitionary SV columns
saurabhd336 opened a new pull request, #9121:
URL: https://github.com/apache/pinot/pull/9121
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `dependencies`
- `docker`
- `kubernetes`
- `observability`
- `security`
- `code-style`
- `extension-point`
- `refactor`
- `cleanup`
(**) Use `release-notes` label for scenarios like:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 commented on pull request #9121: Allow bloom filters for non dicitionary SV columns
Posted by GitBox <gi...@apache.org>.
saurabhd336 commented on PR #9121:
URL: https://github.com/apache/pinot/pull/9121#issuecomment-1197884375
@siddharthteotia I'm raising this in place of https://github.com/apache/pinot/pull/8961. Since the cardinality value needed when creating bloom filter is only required to be an estimate and not exact, I feel the dataSource changes in the previous PR just to get accurate cardinality for the non dictionary column would've been an overkill. Here we're just using total number of entries as the next best estimate instead. Please do have a look.
cc: @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on pull request #9121: Allow bloom filters for non dictionary columns
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on PR #9121:
URL: https://github.com/apache/pinot/pull/9121#issuecomment-1198896285
> @siddharthteotia I'm raising this in place of #8961. Since the cardinality value needed when creating bloom filter is only required to be an estimate and not exact, I feel the dataSource changes in the previous PR just to get accurate cardinality for the non dictionary column would've been an overkill. Here we're just using total number of entries as the next best estimate instead. Please do have a look.
>
> cc: @Jackie-Jiang
Ya that sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #9121: Allow bloom filters for non dictionary columns
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged PR #9121:
URL: https://github.com/apache/pinot/pull/9121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org