You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Alessandro Presta (JIRA)" <ji...@apache.org> on 2012/11/03 00:20:13 UTC
[jira] [Created] (GIRAPH-401) Metrics should be disabled by default
Alessandro Presta created GIRAPH-401:
----------------------------------------
Summary: Metrics should be disabled by default
Key: GIRAPH-401
URL: https://issues.apache.org/jira/browse/GIRAPH-401
Project: Giraph
Issue Type: Improvement
Reporter: Alessandro Presta
Assignee: Alessandro Presta
Priority: Minor
It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (GIRAPH-401) Metrics should be disabled by
default
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alessandro Presta reopened GIRAPH-401:
--------------------------------------
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-401) Metrics should be disabled by
default
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490087#comment-13490087 ]
Nitay Joffe commented on GIRAPH-401:
------------------------------------
That is correct. It is because when I measured it on my job I found the overhead was negligible so I decided to just always enable it. Do you have evidence otherwise, that having it enabled adds a significant amount of overhead?
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-401) Metrics should be disabled by
default
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490811#comment-13490811 ]
Nitay Joffe commented on GIRAPH-401:
------------------------------------
It publishes to JMX by default. We can turn it off if people want, it's not a big deal to me either way.
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-401) Metrics should be disabled by
default
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alessandro Presta resolved GIRAPH-401.
--------------------------------------
Resolution: Fixed
Pretty sure the build failure has to do with the recent dependency issues.
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-401) Metrics should be disabled by
default
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490932#comment-13490932 ]
Nitay Joffe commented on GIRAPH-401:
------------------------------------
Actually I say let's go ahead and put it in, so we don't have anything hidden. Also easier for tests. I +1 this.
We can always reenable it when people want later.
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-401) Metrics should be disabled by default
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alessandro Presta updated GIRAPH-401:
-------------------------------------
Attachment: GIRAPH-401.patch
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-401) Metrics should be disabled by
default
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490986#comment-13490986 ]
Hudson commented on GIRAPH-401:
-------------------------------
Integrated in Giraph-trunk-Commit #267 (See [https://builds.apache.org/job/Giraph-trunk-Commit/267/])
GIRAPH-401: Metrics should be disabled by default (apresta) (Revision 1405984)
Result = FAILURE
apresta : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1405984
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph/src/main/java/org/apache/giraph/metrics/GiraphMetrics.java
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-401) Metrics should be disabled by
default
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490935#comment-13490935 ]
Alessandro Presta commented on GIRAPH-401:
------------------------------------------
Alright, will commit!
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-401) Metrics should be disabled by
default
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490793#comment-13490793 ]
Alessandro Presta commented on GIRAPH-401:
------------------------------------------
I didn't do any measurement. I was just wondering why we keep it enabled by default, even though it's not output anywhere.
> Metrics should be disabled by default
> -------------------------------------
>
> Key: GIRAPH-401
> URL: https://issues.apache.org/jira/browse/GIRAPH-401
> Project: Giraph
> Issue Type: Improvement
> Reporter: Alessandro Presta
> Assignee: Alessandro Presta
> Priority: Minor
> Attachments: GIRAPH-401.patch
>
>
> It seems to me that we are enabling metrics by default, and just disabling console output? Shouldn't metrics be turned off unless requested?
> CC [~nitay]
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira