[GitHub] [superset] justinpark commented on a diff in pull request #21650: chore: Use queryEditorId in SqlEditor child components

[GitBox <gi...@apache.org>]

justinpark commented on code in PR #21650:
URL: https://github.com/apache/superset/pull/21650#discussion_r988322314


##########
superset-frontend/src/SqlLab/components/SaveQuery/index.tsx:
##########
@@ -72,14 +72,14 @@ const Styles = styled.span`
   }
 `;
 
-export default function SaveQuery({
+const SaveQuery = ({
   queryEditorId,
   onSave = () => {},
   onUpdate,
   saveQueryWarning = null,
   database,
   columns,
-}: SaveQueryProps) {
+}: SaveQueryProps) => {

Review Comment:
   nit:
   ```suggestion
   const SaveQuery : React.FC<SaveQueryProps> = ({
     queryEditorId,
     onSave = () => {},
     onUpdate,
     saveQueryWarning = null,
     database,
     columns,
   }) => {
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org