You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chu11 <gi...@git.apache.org> on 2014/04/22 01:37:04 UTC
[GitHub] spark pull request: SPARK-1559
GitHub user chu11 opened a pull request:
https://github.com/apache/spark/pull/471
SPARK-1559
Add conf dir to CLASSPATH dependent on whether SPARK_CONF_DIR is set or not.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chu11/spark SPARK-1559
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/471.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #471
----
commit b9a71ebfd5dc0df2b9d34852c6902bc01a0b8be0
Author: Albert Chu <ch...@llnl.gov>
Date: 2014-04-21T23:26:29Z
Add conf dir to CLASSPATH dependent on whether SPARK_CONF_DIR is set
or not.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1559
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/471#issuecomment-41243371
This technically changes some behavior, but it is what I'd expect. @pwendell / @mateiz thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1559
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/471#issuecomment-54364842
Hi @chu11, the changes here are incorporated in #997. Would you mind closing this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1559
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/471#issuecomment-40989125
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1559
Posted by chu11 <gi...@git.apache.org>.
Github user chu11 closed the pull request at:
https://github.com/apache/spark/pull/471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org