You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/16 09:07:15 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #1799: Find a proper place for registering SAXMessages native resource bundle
JiriOndrusek opened a new pull request #1799:
URL: https://github.com/apache/camel-quarkus/pull/1799
Issue: https://github.com/apache/camel-quarkus/issues/1796
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1799: Find a proper place for registering SAXMessages native resource bundle
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1799:
URL: https://github.com/apache/camel-quarkus/pull/1799#issuecomment-694675677
Solved via quarkusio/quarkus#12144 , esp. https://github.com/quarkusio/quarkus/pull/12144/files#diff-d7d3c24be2a44a5a8077b76e7b3290c6R36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga closed pull request #1799: Find a proper place for registering SAXMessages native resource bundle
Posted by GitBox <gi...@apache.org>.
ppalaga closed pull request #1799:
URL: https://github.com/apache/camel-quarkus/pull/1799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1799: Find a proper place for registering SAXMessages native resource bundle
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1799:
URL: https://github.com/apache/camel-quarkus/pull/1799#issuecomment-693285675
> I think we should first discuss whether Quarkus JAXP extension would not be a better place for this. Apparently, Quarkus JAXP extension does not exist yet. It looks like they put the JAXP stuff into their JAXB extension. I think we should propose splitting their JAXB into JAXB and JAXP and then put the `SAXMessages` registration in the new Quarkus JAXP extension. WDYT, @jamesnetherton ?
Yes, that sounds like a better way. It'll be less stuff that we have to maintain on our side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1799: Find a proper place for registering SAXMessages native resource bundle
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1799:
URL: https://github.com/apache/camel-quarkus/pull/1799#issuecomment-693283408
I think we should first discuss whether Quarkus JAXP extension would not be a better place for this. Apparently, Quarkus JAXP extension does not exist yet. It looks like they put the JAXP stuff into their JAXB extension. I think we should propose splitting their JAXB into JAXB and JAXP and then put the `SAXMessages` registration in the new Quarkus JAXP extension. WDYT, @jamesnetherton ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1799: Find a proper place for registering SAXMessages native resource bundle
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1799:
URL: https://github.com/apache/camel-quarkus/pull/1799#issuecomment-693288669
Filed https://github.com/quarkusio/quarkus/issues/12129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1799: Find a proper place for registering SAXMessages native resource bundle
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1799:
URL: https://github.com/apache/camel-quarkus/pull/1799#issuecomment-693285310
> It looks like they put the JAXP stuff into their JAXB extension
Here:
* https://github.com/quarkusio/quarkus/blob/master/extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java#L196-L199
* https://github.com/quarkusio/quarkus/blob/master/extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java#L205-L206
* https://github.com/quarkusio/quarkus/blob/master/extensions/jaxb/deployment/src/main/java/io/quarkus/jaxb/deployment/JaxbProcessor.java#L210-L214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1799: Find a proper place for registering SAXMessages native resource bundle
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1799:
URL: https://github.com/apache/camel-quarkus/pull/1799#issuecomment-693286009
OK, let me file a Quarkus issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org